Bug 1728714
| Summary: | Openshift-installer binary shows a wrong version commit id | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Ricardo Noriega <rnoriega> | |
| Component: | Installer | Assignee: | Abhinav Dahiya <adahiya> | |
| Installer sub component: | openshift-installer | QA Contact: | Johnny Liu <jialiu> | |
| Status: | CLOSED WONTFIX | Docs Contact: | ||
| Severity: | unspecified | |||
| Priority: | unspecified | CC: | wking | |
| Version: | 4.1.z | |||
| Target Milestone: | --- | |||
| Target Release: | 4.1.z | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1775718 (view as bug list) | Environment: | ||
| Last Closed: | 2019-09-30 17:09:19 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1715001, 1773257, 1790537 | |||
| Bug Blocks: | ||||
|
Description
Ricardo Noriega
2019-07-10 14:05:41 UTC
We can fix this in 4.1.z by backporting [1]. Also in this space and still open for the master branch is [2]. [1]: https://github.com/openshift/installer/pull/1744 [2]: https://github.com/openshift/installer/pull/1829 This is fixed already in 4.2 via installer#1744 (see comment 1). Proof: $ wget https://mirror.openshift.com/pub/openshift-v4/clients/ocp/4.2.0-0.nightly-2019-06-03-135056/openshift-install-linux-4.2.0-0.nightly-2019-06-03-135056.tar.gz $ tar -xf openshift-install-linux-4.2.0-0.nightly-2019-06-03-135056.tar.gz $ ./openshift-install version ./openshift-install unreleased-master-1088-g273cece0ea05bd55ac7d03c5c3022255ea4fd5f7-dirty built from commit 273cece0ea05bd55ac7d03c5c3022255ea4fd5f7 release image quay.io/openshift-release-dev/ocp-release@sha256:8d51bc2da4b9873053b2b3f0737c912ba1e0623ff4b303f1a8ec3618ba3354ff That's [1], so we're good. And checking a more recent internal nightly: $ oc adm release extract --command openshift-install registry.svc.ci.openshift.org/ocp/release:4.2.0-0.nightly-2019-08-15-142751 $ ./openshift-install version ./openshift-install v4.2.0-201908141819-dirty built from commit 6463cd57aa458032fa73aab811f2e6de6fa3c6c5 release image registry.svc.ci.openshift.org/ocp/release@sha256:6810cd11e7616da9a2a38c0edbd21b87240d58760a3296c5f535d1ee0c1c5921 That's [2], so we're good. I'm moving the target to 4.1.z so we can make this discussion about whether we want to backport installer#1744 to 4.1.z. We can also talk about fixing the version name (unreleased-master-1088-g273cece0ea05bd55ac7d03c5c3022255ea4fd5f7-dirty and v4.2.0-201908141819-dirty above, also installer#1829 as mentioned in comment 1), but I think that should go into a new bug. [1]: https://github.com/openshift/installer/commit/273cece0ea05bd55ac7d03c5c3022255ea4fd5f7 [2]: https://github.com/openshift/installer/commit/6463cd57aa458032fa73aab811f2e6de6fa3c6c5 Fixed in 4.2 already, not going to backport to 4.1.z |