Bug 1728714 - Openshift-installer binary shows a wrong version commit id
Summary: Openshift-installer binary shows a wrong version commit id
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.1.z
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.1.z
Assignee: Abhinav Dahiya
QA Contact: Johnny Liu
URL:
Whiteboard:
Depends On: 1715001 1773257 1790537
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-10 14:05 UTC by Ricardo Noriega
Modified: 2020-02-21 21:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1775718 (view as bug list)
Environment:
Last Closed: 2019-09-30 17:09:19 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1715001 0 medium CLOSED oc and openshift-intall version show "dirty" no matter the rc.x clients or extracted from payload 2021-02-22 00:41:40 UTC

Description Ricardo Noriega 2019-07-10 14:05:41 UTC
Description of problem:

Version shows a commit id that is not present in github.

4.1.4 binary from https://mirror.openshift.com/pub/openshift-v4/clients/ocp/latest/
./openshift-install version
./openshift-install v4.1.4-201906271212-dirty
built from commit bf47826c077d16798c556b1bd143a5bbfac14271
release image quay.io/openshift-release-dev/ocp-release@sha256:a6c177eb007d20bb00bfd8f829e99bd40137167480112bd5ae1c25e40a4a163a

Within the openshift-installer repo:
git log bf47826c077d16798c556b1bd143a5bbfac14271
fatal: bad object bf47826c077d16798c556b1bd143a5bbfac14271

Comment 1 W. Trevor King 2019-07-29 17:25:32 UTC
We can fix this in 4.1.z by backporting [1].  Also in this space and still open for the master branch is [2].

[1]: https://github.com/openshift/installer/pull/1744
[2]: https://github.com/openshift/installer/pull/1829

Comment 2 W. Trevor King 2019-08-15 20:47:00 UTC
This is fixed already in 4.2 via installer#1744 (see comment 1).  Proof:

$ wget https://mirror.openshift.com/pub/openshift-v4/clients/ocp/4.2.0-0.nightly-2019-06-03-135056/openshift-install-linux-4.2.0-0.nightly-2019-06-03-135056.tar.gz
$ tar -xf openshift-install-linux-4.2.0-0.nightly-2019-06-03-135056.tar.gz
$ ./openshift-install version
./openshift-install unreleased-master-1088-g273cece0ea05bd55ac7d03c5c3022255ea4fd5f7-dirty
built from commit 273cece0ea05bd55ac7d03c5c3022255ea4fd5f7
release image quay.io/openshift-release-dev/ocp-release@sha256:8d51bc2da4b9873053b2b3f0737c912ba1e0623ff4b303f1a8ec3618ba3354ff

That's [1], so we're good.  And checking a more recent internal nightly:

$ oc adm release extract --command openshift-install registry.svc.ci.openshift.org/ocp/release:4.2.0-0.nightly-2019-08-15-142751
$ ./openshift-install version
./openshift-install v4.2.0-201908141819-dirty
built from commit 6463cd57aa458032fa73aab811f2e6de6fa3c6c5
release image registry.svc.ci.openshift.org/ocp/release@sha256:6810cd11e7616da9a2a38c0edbd21b87240d58760a3296c5f535d1ee0c1c5921

That's [2], so we're good.  I'm moving the target to 4.1.z so we can make this discussion about whether we want to backport installer#1744 to 4.1.z.

We can also talk about fixing the version name (unreleased-master-1088-g273cece0ea05bd55ac7d03c5c3022255ea4fd5f7-dirty and v4.2.0-201908141819-dirty above, also installer#1829 as mentioned in comment 1), but I think that should go into a new bug.

[1]: https://github.com/openshift/installer/commit/273cece0ea05bd55ac7d03c5c3022255ea4fd5f7
[2]: https://github.com/openshift/installer/commit/6463cd57aa458032fa73aab811f2e6de6fa3c6c5

Comment 3 Scott Dodson 2019-09-30 17:09:19 UTC
Fixed in 4.2 already, not going to backport to 4.1.z


Note You need to log in before you can comment on or make changes to this bug.