Bug 1728753

Summary: Make it possible to build with different prefix (rpm2flatpak)
Product: [Fedora] Fedora Reporter: Milan Crha <mcrha>
Component: highlightAssignee: Kevin Fenzi <kevin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: jochen, kevin, lxtnow, rosset.filipe
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: highlight-3.52-2.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-29 01:08:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed patch
none
proposed patch ][ none

Description Milan Crha 2019-07-10 15:32:39 UTC 
Created attachment 1589137 [details]
proposed patch

While playing with rpm2flatpak [1] I found out that the highlight package has trouble to build into a different prefix (the [1] uses /app instead of /usr). The attached patch fixes it. It also changes how man pages are referenced, as suggested here [2].

[1] https://docs.fedoraproject.org/en-US/flatpak/tutorial/
[2] https://docs.fedoraproject.org/en-US/flatpak/troubleshooting/#_uncompressed_manual_pages
Comment 1 Kevin Fenzi 2019-07-10 21:08:06 UTC 
I have no objections to this. You want it just in rawhide, or also in f30-updates?
Comment 2 Milan Crha 2019-07-11 07:40:44 UTC 
No extra preference, though it's true I build rpm2flatpak against f30, thus it would make sense there as well. Thanks.
Comment 3 Milan Crha 2019-07-12 08:20:41 UTC 
Hrm, the

    conf_dir="%{_prefix}/etc/highlight"

might be wrong for the regular build, I'm afraid. Might that rather be this

    conf_dir="%{_sysconfdir}/highlight"

instead?
Comment 4 Milan Crha 2019-07-12 09:08:29 UTC 
Created attachment 1589813 [details]
proposed patch ][

Updated patch, which works both in the flatpak build and in the regular rpm build.
Comment 5 Filipe Rosset 2019-07-12 13:19:56 UTC 
great, I can merge and build during the weekend.
Comment 6 Filipe Rosset 2019-07-13 22:45:49 UTC 
Fixed flatpak builds -> https://src.fedoraproject.org/rpms/highlight/c/501d30d21e511380a9ac054b779a9800e63f3bba?branch=master
Comment 7 Fedora Update System 2019-07-13 23:44:40 UTC 
FEDORA-2019-3bff004fa1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3bff004fa1
Comment 8 Fedora Update System 2019-07-14 03:07:47 UTC 
highlight-3.52-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3bff004fa1
Comment 9 Fedora Update System 2019-07-29 01:08:17 UTC 
highlight-3.52-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.