Bug 1728753 - Make it possible to build with different prefix (rpm2flatpak)
Summary: Make it possible to build with different prefix (rpm2flatpak)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: highlight
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-10 15:32 UTC by Milan Crha
Modified: 2019-07-29 01:08 UTC (History)
4 users (show)

Fixed In Version: highlight-3.52-2.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-29 01:08:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
proposed patch (1.26 KB, patch)
2019-07-10 15:32 UTC, Milan Crha
no flags Details | Diff
proposed patch ][ (1.26 KB, patch)
2019-07-12 09:08 UTC, Milan Crha
no flags Details | Diff

Description Milan Crha 2019-07-10 15:32:39 UTC
Created attachment 1589137 [details]
proposed patch

While playing with rpm2flatpak [1] I found out that the highlight package has trouble to build into a different prefix (the [1] uses /app instead of /usr). The attached patch fixes it. It also changes how man pages are referenced, as suggested here [2].

[1] https://docs.fedoraproject.org/en-US/flatpak/tutorial/
[2] https://docs.fedoraproject.org/en-US/flatpak/troubleshooting/#_uncompressed_manual_pages

Comment 1 Kevin Fenzi 2019-07-10 21:08:06 UTC
I have no objections to this. You want it just in rawhide, or also in f30-updates?

Comment 2 Milan Crha 2019-07-11 07:40:44 UTC
No extra preference, though it's true I build rpm2flatpak against f30, thus it would make sense there as well. Thanks.

Comment 3 Milan Crha 2019-07-12 08:20:41 UTC
Hrm, the

    conf_dir="%{_prefix}/etc/highlight"

might be wrong for the regular build, I'm afraid. Might that rather be this

    conf_dir="%{_sysconfdir}/highlight"

instead?

Comment 4 Milan Crha 2019-07-12 09:08:29 UTC
Created attachment 1589813 [details]
proposed patch ][

Updated patch, which works both in the flatpak build and in the regular rpm build.

Comment 5 Filipe Rosset 2019-07-12 13:19:56 UTC
great, I can merge and build during the weekend.

Comment 7 Fedora Update System 2019-07-13 23:44:40 UTC
FEDORA-2019-3bff004fa1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3bff004fa1

Comment 8 Fedora Update System 2019-07-14 03:07:47 UTC
highlight-3.52-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3bff004fa1

Comment 9 Fedora Update System 2019-07-29 01:08:17 UTC
highlight-3.52-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.