Bug 1731687

Summary:	cockpit-ostree depends on files/directories from non-standard locations
Product:	[Fedora] Fedora	Reporter:	Igor Raits <igor.raits>
Component:	cockpit-ostree	Assignee:	Martin Pitt <mpitt>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mpitt
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cockpit-ostree-179-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-02 01:00:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1731683

Description Igor Raits 2019-07-21 11:10:51 UTC

Hello,

Fedora Packaging Guidelines allow dependencies only on files/directories from /usr/bin, /usr/sbin and /etc directories[0].
Your package depends on files/directories outside of those. See below for more information about package/dependencies.

---
cockpit-ostree-178-1.fc31.noarch:
  - /usr/libexec/rpm-ostreed
---

Please correct those or provide reason why is it correct.
It is very important to not download huge filelists.xml just because few packages in distribution depend on non-standard paths.

Thanks for cooperation!


[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies

Comment 1 Martin Pitt 2019-07-22 10:45:29 UTC

Thanks for spotting! Indeed there is no particular reason, fixed in https://github.com/cockpit-project/cockpit-ostree/pull/22

Comment 2 Martin Pitt 2019-07-22 12:40:03 UTC

The reason was that rpm-ostreed is shipped in "rpm-ostree" in Fedora and CentOS 7 Atomic, but on RHEL atomic it's unhelpfully different ("rpm-ostree-client"). So a file dependency seemed easier, but I used some %iffery for this now.

Comment 3 Igor Raits 2019-07-22 12:47:51 UTC

(In reply to Martin Pitt from comment #2)
> The reason was that rpm-ostreed is shipped in "rpm-ostree" in Fedora and
> CentOS 7 Atomic, but on RHEL atomic it's unhelpfully different
> ("rpm-ostree-client"). So a file dependency seemed easier, but I used some
> %iffery for this now.

What about moving rpm-ostreed into /usr/bin or /usr/sbin then?

Comment 4 Martin Pitt 2019-07-22 13:15:29 UTC

@Igor: that's not really my decision to take, but that also sounds wrong -- it's a daemon, not a program that users should call in $PATH. As I said, that was just a workaround for this package difference, the above PR fixes it.

Comment 5 Fedora Update System 2019-07-24 09:49:07 UTC

FEDORA-2019-f2b540ebdf has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f2b540ebdf

Comment 6 Fedora Update System 2019-07-25 01:19:53 UTC

cockpit-ostree-179-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f2b540ebdf

Comment 7 Fedora Update System 2019-08-02 01:00:55 UTC

cockpit-ostree-179-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.