Bug 1731849

Summary:	[machines] Disk failed to be created with iscsi-pool on Add Disk page
Product:	Red Hat Enterprise Linux 8	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-appstream	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	mpitt, wshi, ymao, yunyang
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.1
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-05 20:41:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2019-07-22 08:21:25 UTC

Description of problem:
Disk failed to be created with iscsi-pool on Add Disk page, the iscsi-pool should be gray or the Create New should be gray when choosing iscsi-pool if it's expected not to create new disk with iscsi-pool.


Version-Release number of selected component (if applicable):
cockpit-machines-197-1.el8.noarch
libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a iscsi-pool and add it in the Storage Pools
2. Prepare a VM, open the Disks tab, click Add Disk
3. Options as following:
Source: Create New
Pool: iscsi-pool
Name: test
Size: 1 GiB
4. Click Add


Actual results:
An error prompt:
Disk failed to be created
Error message: this function is not supported by the connection driver: storage pool does not support volume creation


Expected results:
The disk can be created or the iscsi-pool should be gray or the Create New should be gray when choosing iscsi-pool if it's expected not to create new disk with iscsi-pool.


Additional info:

Comment 1 Martin Pitt 2019-07-23 10:47:07 UTC

Fixed in https://github.com/cockpit-project/cockpit/pull/12388

Comment 3 Xianghua Chen 2019-08-05 08:09:07 UTC

Verified with package:
cockpit-machines-197.1-1.el8.noarch

Steps:
1. Prepare a iscsi-pool and add it in the Storage Pools
2. Prepare a VM, open the Disks tab, click Add Disk
3. Options as following:
Source: Create New
The Pool "iscsi-pool" now is gray and there is a hint saying :
This pool type does not support Storage Volume creation.

So verified.

Comment 5 errata-xmlrpc 2019-11-05 20:41:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3325