Bug 1732142

Summary:	[RFE] Changing BlueStore OSD rocksdb_cache_size default value to 512MB for helping in compaction
Product:	[Red Hat Storage] Red Hat Ceph Storage	Reporter:	Vikhyat Umrao <vumrao>
Component:	RADOS	Assignee:	Neha Ojha <nojha>
Status:	CLOSED ERRATA	QA Contact:	Manohar Murthy <mmurthy>
Severity:	medium	Docs Contact:	Erin Donnelly <edonnell>
Priority:	medium
Version:	3.2	CC:	agunn, ceph-eng-bugs, dzafman, edonnell, kchai, nojha, pasik, tchandra, tserlin
Target Milestone:	rc	Keywords:	CodeChange, FutureFeature
Target Release:	3.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ceph-12.2.11	Doc Type:	Enhancement
Doc Text:	.The `rocksdb_cache_size` option default is now 512 MB BlueStore OSD `rocksdb_cache_size` option default value has been changed to 512 MB to help with compaction.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-21 15:11:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1726135, 1733598

Description Vikhyat Umrao 2019-07-22 19:18:47 UTC

Description of problem:
[RFE] Changing BlueStore OSD rocksdb_cahce_size default value to 512MB for helping in compaction

Version-Release number of selected component (if applicable):
RHCS 3.2

Comment 1 Vikhyat Umrao 2019-07-22 19:19:14 UTC

The current default value is 128MB.

Comment 3 Vikhyat Umrao 2019-07-22 21:46:17 UTC

commit 8ff3c083ecc82345bbeb0b33d28408f9a95e5b1a
Author: Sage Weil <sage>
Date:   Mon Sep 24 09:21:20 2018 -0500

    rocksdb: increase default cache size to 512 MB
    
    For filestore OSDs, this is probably a good idea anyway, and is generally
    not going to be hugely impactful on the memory footprint (where users
    have been told to provide 1 GB RAM per 1 TB storage for a long time now).
    
    For bluestore OSDs, this value is meaningless as we're autotuning this
    anyway.
    
    For mons, this is a more reasonable default.
    
    Signed-off-by: Sage Weil <sage>
    (cherry picked from commit cbfc3ee1921f4780be6d4071e441818b1390101c)
    
    Conflicts:
            src/common/options.cc
    - trivial resolution

diff --git a/src/common/options.cc b/src/common/options.cc
index 25158e71ba..43353551e0 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -2956,7 +2956,7 @@ std::vector<Option> get_global_options() {
     .set_description(""),
 
     Option("rocksdb_cache_size", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(128_M)
+    .set_default(512_M)
     .set_description(""),


$ git tag --contains 8ff3c083ecc
v12.2.11
v12.2.12


git tag --contains cbfc3ee1921
v14.0.1
v14.1.0
v14.1.1
v14.2.0
v14.2.1
v14.2.2
v15.0.0

This is already part of 3.3 and 4.0 rebase.

Comment 11 Giridhar Ramaraju 2019-08-05 13:10:44 UTC

Updating the QA Contact to a Hemant. Hemant will be rerouting them to the appropriate QE Associate. 

Regards,
Giri

Comment 12 Giridhar Ramaraju 2019-08-05 13:11:46 UTC

Updating the QA Contact to a Hemant. Hemant will be rerouting them to the appropriate QE Associate. 

Regards,
Giri

Comment 15 errata-xmlrpc 2019-08-21 15:11:10 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2538