Bug 1734198
Summary: | g-i-s crashes if timedatex.service isn't running | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
Component: | gnome-initial-setup | Assignee: | Rui Matos <tiagomatos> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 31 | CC: | gnome-sig, jstpierr, leandroembu, mcatanzaro+wrong-account-do-not-cc, robatino, sshedmak, tiagomatos, zbyszek |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | openqa | ||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-11-24 18:50:09 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Adam Williamson
2019-07-29 23:36:28 UTC
https://gitlab.gnome.org/GNOME/gnome-initial-setup/blob/master/gnome-initial-setup/pages/timezone/gis-timezone-page.c#L383 is where the crash happens, BTW: priv->dtm = timedate1_proxy_new_for_bus_sync (G_BUS_TYPE_SYSTEM, G_DBUS_PROXY_FLAGS_NONE, "org.freedesktop.timedate1", "/org/freedesktop/timedate1", NULL, &error); if (priv->dtm == NULL) { g_error ("Failed to create proxy for timedated: %s", error->message); exit (1); } See also https://bugzilla.redhat.com/show_bug.cgi?id=1735584: taking timedatex out of the picture might or might not help with this. FWIW I think it's reasonable for this to be fatal. Distros should skip the page if timedated won't be running at install time. And we should fix our timedated. :) (In reply to Adam Williamson from comment #1) > if (priv->dtm == NULL) { > g_error ("Failed to create proxy for timedated: %s", error->message); > exit (1); > } This is a little weird because the exit (1) is unreachable (because g_error() never returns). > FWIW I think it's reasonable for this to be fatal.
Please, no. There should be some resiliency in the system. If the dbus call fails, just show the error and continue.
Stuff like this happens, will happen in the future, and things must not just fall apart.
Well this is the timezone configuration step in the initial setup wizard. It really cannot possibly work without timedated. Only reasonable behavior is to skip ahead to the next page and leave the system configured with the default timezone, but I think I'd much rather get a crash report instead. Notably, this page will only run for the very first user account and will be skipped for any subsequently-created user accounts, so at this point there's nothing a user can have done to sabotage timedated. You don't just get a crash notification and the screen is skipped, though. The entire g-i-s does not run, and since you can't create a user account or root password during anaconda in workstation, that means the system is unusable. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. Anyway, surely this shouldn't be a blocker if it's been fixed by selinux. (In reply to Adam Williamson from comment #6) > You don't just get a crash notification and the screen is skipped, though. > The entire g-i-s does not run, and since you can't create a user account or > root password during anaconda in workstation, that means the system is > unusable. To be clear: my position is that this is desired behavior and no g-i-s change is required. The crash is intentional SIGABRT with a nice error message, not a programming mistake "Anyway, surely this shouldn't be a blocker if it's been fixed by selinux." Yeah, it doesn't need to be one any more. "The crash is intentional SIGABRT with a nice error message, not a programming mistake" From the perspective of the app, fine. From the perspective of the system the app is embedded in...not really. The 'nice error message' is not visible and is impossible to find unless you happened to hack in a root user before rebooting from the installer, or you take the trouble to reboot back to the installer or some other bootable environment and chroot into the broken installed system or something. Yep, that's just bad user experience. Let's consider a similar case: if I stop NetworkManager, and navigate to the network settings panel, I get a message "Oops, something went wrong. NetworkManager is not running." (from memory, so probably not exactly like that). It would be great if g-i-s could behave like this too. *** Bug 1735564 has been marked as a duplicate of this bug. *** *** Bug 1739614 has been marked as a duplicate of this bug. *** This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |