Bug 1734709
| Summary: | Group by list labels should not wrap | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Yadan Pei <yapei> | ||||||||
| Component: | Management Console | Assignee: | Robb Hamilton <rhamilto> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 4.2.0 | CC: | aos-bugs, jhadvig, jokerman, rhamilto, spadgett, yapei | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | 4.2.0 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2019-10-16 06:34:11 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Yadan Pei
2019-07-31 09:40:01 UTC
Created attachment 1595006 [details]
GroupResourcesLists
registry.svc.ci.openshift.org/ocp/release:4.2.0-0.nightly-2019-08-01-224308
$ oc get pods -n openshift-console console-7b75cfb59-cj4g8 -o yaml | grep -i image
console.openshift.io/image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:8d20a809075cdf697eddc17a6116f7c1b762ae2d8af18708ff6a597cd0590678
$ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:8d20a809075cdf697eddc17a6116f7c1b762ae2d8af18708ff6a597cd0590678 | grep -i commit
io.openshift.build.commit.url=https://github.com/openshift/console/commit/ee83581394a880fa7f33b971b4e331133725916
$ git log ee83581394a880fa7f33b971b4e3311337259168 | grep '#2235' # to confirm PR #2235 is merged
Merge pull request #2235 from rhamilto/bz-1734709
But the 'Group by' dropdown list are still not correctly wrapped
Robb, can you confirm?
Created attachment 1600566 [details]
GroupByMultipleLabels
I saw only 5 labels in PR screenshot, would you try a few more labels and to see if you can reproduce? Thanks very much I'm confused... The last screenshot looks correct to me. What is the issue? The number of items should not matter. The label names themselves might matter, though. Created attachment 1601684 [details]
GroupBY
The Labels in green color should be grouped with other labels(should be moved up in this case), and we should have a divider between Label and Application, Resource as shown in the PR 2235 Yadan, would you please open a separate bug with clear steps to reproduce the ordering issue since this bug initially reported an issue with app labels wrapping? That way we have a clearer trail of what the bug is and how to fix. I agree the ordering / grouping is a problem, but it's really a different issue than the wrapping problem. We should open a different bug. Do you mind? Moving this one back to ON_QA. We're having trouble reproducing the grouping problem, so any steps you can provide would be helpful. Thank you Sam, Robb I didn't reproduce the issues in comment 3 today 1. Developer Console -> +Add -> Browse Catalog -> Source-to-image -> php -> Create Application -> in Application section, choose 'Create New Application', and set 'Application Name' as testphp, and click Try Sample -> Create 2. Developer Console -> +Add -> Browse Catalog -> Source-to-image -> python -> Create Application -> in Application section, it will defaults to 'testphp', this time set 'Name' as testpython, and click Try Sample -> Create 3. Go back to Administration console, Home -> Projects -> Workloads -> Group By Group By has correct layout, and labels are not wrapping Verified on quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:d610d5b20346f54512d13ccad34bda66419f3f56b4c1f6cb6abca683cc862187 with console commit: io.openshift.build.commit.url=https://github.com/openshift/console/commit/3d9532a92e0b2643418b8a51266cacdaec163a12 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2922 |