Bug 1734709 - Group by list labels should not wrap
Summary: Group by list labels should not wrap
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.2.0
Assignee: Robb Hamilton
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-31 09:40 UTC by Yadan Pei
Modified: 2019-10-16 06:34 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-16 06:34:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
GroupResourcesLists (87.10 KB, image/png)
2019-07-31 09:40 UTC, Yadan Pei
no flags Details
GroupByMultipleLabels (54.32 KB, image/png)
2019-08-05 07:24 UTC, Yadan Pei
no flags Details
GroupBY (52.67 KB, image/png)
2019-08-08 05:33 UTC, Yadan Pei
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 2235 0 None None None 2019-07-31 17:53:51 UTC
Red Hat Product Errata RHBA-2019:2922 0 None None None 2019-10-16 06:34:23 UTC

Description Yadan Pei 2019-07-31 09:40:01 UTC
Description of problem:
as title

Version-Release number of selected component (if applicable):
4.2.0-0.nightly-2019-07-30-155738

How reproducible:
Always

Steps to Reproduce:
1. Create Application from Deploy Image
2. Create another app from Deploy Image and add it to the app we created in step1
3. Create some other apps and add labels for the resources
4. Home -> Project -> Workloads -> Group by:
 
Actual results:
4. The Group by lists are in a mess, see screenshot

Expected results:
4. The Group by should have clear lists

Additional info:
Not sure what's the root cause since the apps are created randomly, maybe many labels

Comment 1 Yadan Pei 2019-07-31 09:40:31 UTC
Created attachment 1595006 [details]
GroupResourcesLists

Comment 3 Yadan Pei 2019-08-05 07:23:35 UTC
registry.svc.ci.openshift.org/ocp/release:4.2.0-0.nightly-2019-08-01-224308
$ oc get pods -n openshift-console console-7b75cfb59-cj4g8 -o yaml | grep -i image
    console.openshift.io/image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:8d20a809075cdf697eddc17a6116f7c1b762ae2d8af18708ff6a597cd0590678
$ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:8d20a809075cdf697eddc17a6116f7c1b762ae2d8af18708ff6a597cd0590678 | grep -i commit
io.openshift.build.commit.url=https://github.com/openshift/console/commit/ee83581394a880fa7f33b971b4e331133725916

$ git log ee83581394a880fa7f33b971b4e3311337259168 | grep '#2235'         # to confirm PR #2235 is merged 
    Merge pull request #2235 from rhamilto/bz-1734709

But the 'Group by' dropdown list are still not correctly wrapped

Robb, can you confirm?

Comment 4 Yadan Pei 2019-08-05 07:24:23 UTC
Created attachment 1600566 [details]
GroupByMultipleLabels

Comment 5 Yadan Pei 2019-08-05 07:25:38 UTC
I saw only 5 labels in PR screenshot, would you try a few more labels and to see if you can reproduce? Thanks very much

Comment 6 Samuel Padgett 2019-08-07 17:20:29 UTC
I'm confused... The last screenshot looks correct to me. What is the issue?

The number of items should not matter. The label names themselves might matter, though.

Comment 7 Yadan Pei 2019-08-08 05:33:33 UTC
Created attachment 1601684 [details]
GroupBY

Comment 8 Yadan Pei 2019-08-08 05:36:27 UTC
The Labels in green color should be grouped with other labels(should be moved up in this case), and we should have a divider between Label and Application, Resource as shown in the PR 2235

Comment 9 Robb Hamilton 2019-08-12 14:32:12 UTC
Yadan, would you please open a separate bug with clear steps to reproduce the ordering issue since this bug initially reported an issue with app labels wrapping?  That way we have a clearer trail of what the bug is and how to fix.

Comment 10 Samuel Padgett 2019-08-12 15:01:39 UTC
I agree the ordering / grouping is a problem, but it's really a different issue than the wrapping problem. We should open a different bug. Do you mind? Moving this one back to ON_QA.

We're having trouble reproducing the grouping problem, so any steps you can provide would be helpful.

Comment 11 Yadan Pei 2019-08-13 06:48:30 UTC
Thank you Sam, Robb

I didn't reproduce the issues in comment 3 today

1. Developer Console -> +Add -> Browse Catalog -> Source-to-image -> php -> Create Application -> in Application section, choose 'Create New Application', and set 'Application Name' as testphp, and click Try Sample -> Create
2. Developer Console -> +Add -> Browse Catalog -> Source-to-image -> python -> Create Application -> in Application section, it will defaults to 'testphp', this time set 'Name' as testpython, and click Try Sample -> Create
3. Go back to Administration console, Home -> Projects -> Workloads -> Group By 


Group By has correct layout, and labels are not wrapping 


Verified on quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:d610d5b20346f54512d13ccad34bda66419f3f56b4c1f6cb6abca683cc862187 with console commit:
io.openshift.build.commit.url=https://github.com/openshift/console/commit/3d9532a92e0b2643418b8a51266cacdaec163a12

Comment 12 errata-xmlrpc 2019-10-16 06:34:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922


Note You need to log in before you can comment on or make changes to this bug.