Bug 1735361
| Summary: | sys.puts is not a function | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stuart D Gathman <stuart> | ||||||
| Component: | nodejs-ronn | Assignee: | NodeJS Packaging SIG <nodejs-sig> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | urgent | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 31 | CC: | nodejs-sig, tchollingsworth | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | nodejs-ronn-0.4.0-16.fc32 nodejs-ronn-0.4.0-16.fc31 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2020-05-30 01:53:52 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1735015 | ||||||||
| Attachments: |
|
||||||||
Created attachment 1596551 [details]
cjdns-online.md
Attaching the md file that it failed on so you can test without actually building cjdns.
Looks like nodejs-12 took away the util.puts(). That is used as sys.puts() for stderr. I'm sure there is a simple replacement, but I'm not up on node. Even in nodejs-10 sys.puts() is deprecated. Says use console.log() instead. That sounds like a search and replace. The github page says the project has been moved to marked-man. marked-man has a single dependency: marked, which is supplied by Fedora. A patch can make it work. Change:
var sys = require('sys');
to:
var console = require('console');
var sys = { 'puts': console.log, 'debug': console.error };
In bin/ronn.js and lib/ronn.js
Created attachment 1600215 [details]
patch ronn to stop using deprecated util.puts and util.debug
I worked around the problem for now by making a local copy of ronn in cjdns build directory, and applying the patch.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. I submitted a PR to rpms/nodejs-ronn FEDORA-2020-e25557eb2f has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e25557eb2f FEDORA-2020-4ca6565ae6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4ca6565ae6 FEDORA-2020-874c8d3f48 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-874c8d3f48 FEDORA-2020-4ca6565ae6 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4ca6565ae6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4ca6565ae6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-874c8d3f48 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-874c8d3f48` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-874c8d3f48 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-e25557eb2f has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-e25557eb2f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e25557eb2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-874c8d3f48 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-4ca6565ae6 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. |
Description of problem: Does not convert markdown to nroff Version-Release number of selected component (if applicable): nodejs-ronn-0.4.0-13.fc30.noarch How reproducible: always Steps to Reproduce: 1. build cjdns for f31/rawhide at 9c6fb6c6d91bae6e8e063c07f49d3f96006b5c61 Actual results: + ronn-nodejs cjdns-online.md /usr/lib/node_modules/ronn/bin/ronn.js:109 if (fRoff) sys.puts(fRoff); ^ TypeError: sys.puts is not a function at render (/usr/lib/node_modules/ronn/bin/ronn.js:109:19) at Object.<anonymous> (/usr/lib/node_modules/ronn/bin/ronn.js:62:2) at Module._compile (internal/modules/cjs/loader.js:776:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10) at Module.load (internal/modules/cjs/loader.js:643:32) at Function.Module._load (internal/modules/cjs/loader.js:556:12) at Function.Module.runMain (internal/modules/cjs/loader.js:839:10) at internal/main/run_main_module.js:17:11 Expected results: nroff output Additional info: