Bug 1736598
Summary: | rubygem-asciidoctor: FTBFS in Fedora rawhide/f31 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Fedora Release Engineering <releng> | ||||||||
Component: | rubygem-asciidoctor | Assignee: | Todd Zullinger <tmz> | ||||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 31 | CC: | dan.j.allen, ktdreyer, tmz | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2020-01-18 02:30:26 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 1700317, 1732841 | ||||||||||
Attachments: |
|
Description
Fedora Release Engineering
2019-08-01 19:06:24 UTC
Created attachment 1599051 [details]
build.log
file build.log too big, will only attach last 32768 bytes
Created attachment 1599052 [details]
root.log
file root.log too big, will only attach last 32768 bytes
Created attachment 1599053 [details]
state.log
Perhaps it's time to revisit the move to asciidoctor-2.x in rawhide? I've been busy for a while and haven't rebuilt every app which depends on asciidoctor since the early 2.0 releases, but even then the results were pretty good. That's in PR: https://src.fedoraproject.org/rpms/rubygem-asciidoctor/pull-request/2 A scratch build of the latest 2.0.10 builds cleanly. Here's the result: https://koji.fedoraproject.org/koji/taskinfo?taskID=36741536 I'll mention this in the PR as well. We're getting close to the time we need to avoid such a change in rawhide, of course. This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31. Dear Maintainer, your package has not been built successfully in 31. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. Following the latest policy for such packages [2], your package can be orphaned if this bug remains in NEW state more than 8 weeks. A week before the mass branching of Fedora 32 according to the schedule [3], any packages which still have open FTBFS bugs from Fedora 31 will be retired. [1] https://fedoraproject.org/wiki/Updates_Policy [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedoraproject.org/wiki/Releases/32/Schedule Now looks like the time we need to merge PR2 and update to 2.0.10 in rawhide. I'll ping the PR again to see if there's any objections there. If not, I'll look at announcing the rawhide version bump in rawhide in the next few days. An upgrade alone may not solve the problem...or it might. Here's the test that's failing: 1) Failure: Minitest::Test::TestInvoker#test_should_show_timezone_as_offset_if_system_TZ_is_not_set_to_UTC [/builddir/build/BUILD/asciidoctor-1.5.8/usr/share/gems/gems/asciidoctor-1.5.8/test/invoker_test.rb:698]: Expected false to be truthy. This is the line that's not taking effect: ENV['TZ'] = 'EST+5' I think the logic in 1.5.8 had a conflict with the SOURCE_DATA_EPOCH environment variable. That test has since been rewritten to use: output = run_command({ 'TZ' => 'EST+5', 'SOURCE_DATE_EPOCH' => nil }, %(#{asciidoctor_cmd} -d inline -o - -s #{input_path})) {|out| out.read } See this commit: https://github.com/asciidoctor/asciidoctor/commit/4941cd55f392744366f7d35a73ccfb639ef368cf I definitely recommend the upgrade to Asciidoctor 2.0. There will be no more 1.5.x releases. Thanks Dan, that sounds good to me. I'll plan to merge PR 2 which updates to 2.0.10 in the next few days. I have run numerous scratch builds and 2.x builds and passes all its tests, so we'll fix this issue while we move to a current asciidoctor release. Perfect! Dear Maintainer, your package has not been built successfully in 31. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. Following the latest policy for such packages [2], your package can be orphaned if this bug remains in NEW state more than 8 weeks. A week before the mass branching of Fedora 32 according to the schedule [3], any packages which still have open FTBFS bugs from Fedora 31 will be retired. [1] https://fedoraproject.org/wiki/Updates_Policy [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedoraproject.org/wiki/Releases/32/Schedule Setting the status to ASSIGNED to let the automated tools know we're working on this. I'm planning to push the update to 2.0.10 tomorrow, which will resolve the FTBFS for rawhide. I don't think we need to do anything for the f31 branch, but I can look at that later. I thought that the latest 1.5.8 on the f31 branch did build, but it's been a while since I tested that. Closing, as rubygem-asciidoctor-2.0.10-1.fc32 was built for rawhide in September. |