Bug 1736598 - rubygem-asciidoctor: FTBFS in Fedora rawhide/f31
Summary: rubygem-asciidoctor: FTBFS in Fedora rawhide/f31
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-asciidoctor
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Todd Zullinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F31FTBFS 1732841
TreeView+ depends on / blocked
 
Reported: 2019-08-01 19:06 UTC by Fedora Release Engineering
Modified: 2019-09-29 05:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)
build.log (32.00 KB, text/plain)
2019-08-01 19:06 UTC, Fedora Release Engineering
no flags Details
root.log (32.00 KB, text/plain)
2019-08-01 19:06 UTC, Fedora Release Engineering
no flags Details
state.log (669 bytes, text/plain)
2019-08-01 19:06 UTC, Fedora Release Engineering
no flags Details

Description Fedora Release Engineering 2019-08-01 19:06:24 UTC
rubygem-asciidoctor failed to build from source in Fedora rawhide/f31

https://koji.fedoraproject.org/koji/taskinfo?taskID=36637460


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Please fix rubygem-asciidoctor at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
rubygem-asciidoctor will be orphaned. Before branching of Fedora 32,
rubygem-asciidoctor will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2019-08-01 19:06:34 UTC
Created attachment 1599051 [details]
build.log

file build.log too big, will only attach last 32768 bytes

Comment 2 Fedora Release Engineering 2019-08-01 19:06:41 UTC
Created attachment 1599052 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2019-08-01 19:06:42 UTC
Created attachment 1599053 [details]
state.log

Comment 4 Todd Zullinger 2019-08-01 20:47:03 UTC
Perhaps it's time to revisit the move to asciidoctor-2.x in rawhide?  I've been busy for a while and haven't rebuilt every app which depends on asciidoctor since the early 2.0 releases, but even then the results were pretty good.

That's in PR:

    https://src.fedoraproject.org/rpms/rubygem-asciidoctor/pull-request/2

A scratch build of the latest 2.0.10 builds cleanly.  Here's the result:

    https://koji.fedoraproject.org/koji/taskinfo?taskID=36741536

I'll mention this in the PR as well.  We're getting close to the time we need to avoid such a change in rawhide, of course.

Comment 5 Ben Cotton 2019-08-13 18:02:02 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 6 Fedora Release Engineering 2019-09-22 04:34:59 UTC
Dear Maintainer,

your package has not been built successfully in 31. Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. Following the latest policy for such packages [2], your package
can be orphaned if this bug remains in NEW state more than 8 weeks.

A week before the mass branching of Fedora 32 according to the schedule [3],
any packages which still have open FTBFS bugs from Fedora 31 will be retired.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedoraproject.org/wiki/Releases/32/Schedule

Comment 7 Todd Zullinger 2019-09-22 14:26:09 UTC
Now looks like the time we need to merge PR2 and update to 2.0.10 in rawhide.  I'll ping the PR again to see if there's any objections there.  If not, I'll look at announcing the rawhide version bump in rawhide in the next few days.

Comment 8 Dan Allen 2019-09-23 05:40:46 UTC
An upgrade alone may not solve the problem...or it might. Here's the test that's failing:

  1) Failure:
Minitest::Test::TestInvoker#test_should_show_timezone_as_offset_if_system_TZ_is_not_set_to_UTC [/builddir/build/BUILD/asciidoctor-1.5.8/usr/share/gems/gems/asciidoctor-1.5.8/test/invoker_test.rb:698]:
Expected false to be truthy.

This is the line that's not taking effect:

ENV['TZ'] = 'EST+5'

I think the logic in 1.5.8 had a conflict with the SOURCE_DATA_EPOCH environment variable. That test has since been rewritten to use:

output = run_command({ 'TZ' => 'EST+5', 'SOURCE_DATE_EPOCH' => nil }, %(#{asciidoctor_cmd} -d inline -o - -s #{input_path})) {|out| out.read }

See this commit: https://github.com/asciidoctor/asciidoctor/commit/4941cd55f392744366f7d35a73ccfb639ef368cf

Comment 9 Dan Allen 2019-09-23 05:42:06 UTC
I definitely recommend the upgrade to Asciidoctor 2.0. There will be no more 1.5.x releases.

Comment 10 Todd Zullinger 2019-09-23 06:15:16 UTC
Thanks Dan, that sounds good to me.  I'll plan to merge PR 2 which updates to 2.0.10 in the next few days.

I have run numerous scratch builds and 2.x builds and passes all its tests, so we'll fix this issue while we move to a current asciidoctor release.

Comment 11 Dan Allen 2019-09-23 06:24:59 UTC
Perfect!

Comment 12 Fedora Release Engineering 2019-09-29 04:23:00 UTC
Dear Maintainer,

your package has not been built successfully in 31. Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. Following the latest policy for such packages [2], your package
can be orphaned if this bug remains in NEW state more than 8 weeks.

A week before the mass branching of Fedora 32 according to the schedule [3],
any packages which still have open FTBFS bugs from Fedora 31 will be retired.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedoraproject.org/wiki/Releases/32/Schedule

Comment 13 Todd Zullinger 2019-09-29 05:43:21 UTC
Setting the status to ASSIGNED to let the automated tools know we're working on this.  I'm planning to push the update to 2.0.10 tomorrow, which will resolve the FTBFS for rawhide.  I don't think we need to do anything for the f31 branch, but I can look at that later.  I thought that the latest 1.5.8 on the f31 branch did build, but it's been a while since I tested that.


Note You need to log in before you can comment on or make changes to this bug.