Bug 1737088

Summary:	Review Request: perl-XRD-Parser - Parse XRD and host-meta files into RDF::Trine models
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-XRD-Parser-0.201-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-05 14:36:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1737059
Bug Blocks:

Description Petr Pisar 2019-08-02 14:57:47 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-XRD-Parser/perl-XRD-Parser.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-XRD-Parser/perl-XRD-Parser-0.201-1.fc31.src.rpm
Description:
While XRD has a rather different history, it turns out it can mostly be
thought of as a serialization format for a limited subset of RDF.

This parser ignores the order of Link elements, as RDF is a graph format with
no concept of statements coming in an "order". The XRD spec says that grokking
the order of Link elements is only a SHOULD. That said, if you're concerned
about the order of Link elements, the callback routines allowed by this
package may be of use.

This package aims to be roughly compatible with RDF::RDFa::Parser's interface.

Fedora Account System Username: ppisar

Comment 1 Robert-André Mauchin 🐧 2019-08-02 21:05:42 UTC

URL and Source addresses are Ok.
Source archive (SHA-256: 5236f5f02a7cb22137c8bfb9c645fffea9eb4411f022e00338d6c2aa3e34e891) is original. Ok.
Summary verified from lib/XRD/Parser.pm. Ok.
Description verified from lib/XRD/Parser.pm. Ok.
License verified from lib/XRD/Parser.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

$ rpmlint perl-XRD-Parser.spec  review-perl-XRD-Parser/results/perl-XRD-Parser-0.201-1.fc31.noarch.rpm  review-perl-XRD-Parser/results/perl-XRD-Parser-0.201-1.fc31.src.rpm 
perl-XRD-Parser.noarch: W: spelling-error Summary(en_US) Trine -> Trina, Taine, Urine
perl-XRD-Parser.noarch: W: spelling-error %description -l en_US RDFa -> Rd Fa, Rd-fa, RDA
perl-XRD-Parser.src: W: spelling-error Summary(en_US) Trine -> Trina, Taine, Urine
perl-XRD-Parser.src: W: spelling-error %description -l en_US RDFa -> Rd Fa, Rd-fa, RDA
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpm -q -lv -p perl-XRD-Parser-0.201-1.fc31.noarch.rpm
drwxr-xr-x    2 root    root                        0 Aug  2 22:45 /usr/share/doc/perl-XRD-Parser
-rw-r--r--    1 root    root                     2559 Aug  2 22:45 /usr/share/doc/perl-XRD-Parser/Changes
-rw-r--r--    1 root    root                     8591 Aug  2 22:45 /usr/share/doc/perl-XRD-Parser/README
drwxr-xr-x    2 root    root                        0 Sep 11  2012 /usr/share/doc/perl-XRD-Parser/examples
-rw-r--r--    1 root    root                     1028 Nov 27  2011 /usr/share/doc/perl-XRD-Parser/examples/basic.pl
-rw-r--r--    1 root    root                      186 Nov 27  2011 /usr/share/doc/perl-XRD-Parser/examples/hostmeta.pl
drwxr-xr-x    2 root    root                        0 Aug  2 22:45 /usr/share/licenses/perl-XRD-Parser
-rw-r--r--    1 root    root                    18406 Aug  2 22:45 /usr/share/licenses/perl-XRD-Parser/LICENSE
-rw-r--r--    1 root    root                     4558 Aug  2 22:45 /usr/share/man/man3/XRD::Parser.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug  2 22:45 /usr/share/perl5/vendor_perl/XRD
-rw-r--r--    1 root    root                    31036 Sep 11  2012 /usr/share/perl5/vendor_perl/XRD/Parser.pm
File permissions and layout are Ok.


$ rpm -q --requires -p perl-XRD-Parser-0.201-1.fc31.noarch.rpm | sort -f | uniq -c     23:00:54
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(Carp) >= 0
      1 perl(constant)
      1 perl(Digest::SHA) >= 0
      1 perl(Encode) >= 0
      1 perl(HTTP::Link::Parser) >= 0.102
      1 perl(LWP::UserAgent) >= 0
      1 perl(Object::AUTHORITY) >= 0
      1 perl(RDF::Trine) >= 0.135
      1 perl(Scalar::Util) >= 0
      1 perl(strict)
      1 perl(URI::Escape) >= 0
      1 perl(URI::URL) >= 0
      1 perl(warnings)
      1 perl(XML::LibXML) >= 1.70
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

rpm -q --provides -p perl-XRD-Parser-0.201-1.fc31.noarch.rpm
perl(XRD::Parser) = 0.201
perl-XRD-Parser = 0.201-1.fc31
Binary provides are Ok.

Package builds in Mock.
Ok


Resolution: Package approved.

Comment 2 Gwyn Ciesla 2019-08-05 13:35:29 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-XRD-Parser

Comment 3 Petr Pisar 2019-08-05 14:36:01 UTC

Thank you for the review and the repository.