Bug 1737558

Summary: must-gather does not collect PVCs and events in openshift-image-registry namespace
Product: OpenShift Container Platform Reporter: Jan Safranek <jsafrane>
Component: Image RegistryAssignee: Oleg Bulatov <obulatov>
Status: CLOSED ERRATA QA Contact: Wenjing Zheng <wzheng>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.1.0CC: adam.kaplan, aos-bugs, deads, erich
Target Milestone: ---   
Target Release: 4.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: not all resources are collected by must-gather Consequence: PVCs are not collected Fix: collect PVC Result: PVCs are collected
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-16 06:34:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Safranek 2019-08-05 16:11:04 UTC
Debugging of storage related problems in the cluster is hard, because must-gather does not collect PVCs and events in openshift-image-registry namespace.

image-registry should include those in its status.relatedObjects.

Version-Release number of selected component (if applicable):
4.2.0-0.okd-2019-08-05-143844

How reproducible:
always

Steps to Reproduce:
1. oc adm must-gather

Actual results:
create must-gather.local.4036446028965045097/namespaces/openshift-image-registry/core does not contain events nor PVCs

Comment 1 Oleg Bulatov 2019-08-16 15:12:35 UTC
We won't add events to relatedObjects (as far as I know, no operator is doing that), but PVC should be there.

Comment 2 Adam Kaplan 2019-08-20 19:05:45 UTC
*** Bug 1743837 has been marked as a duplicate of this bug. ***

Comment 3 Adam Kaplan 2019-08-20 19:41:03 UTC
Adding the "openshift-image-registry" namespace should be sufficient. We can drop all objects within that namespace from the related objects list.

Comment 4 Oleg Bulatov 2019-08-20 21:46:18 UTC
As I can see, it's not sufficient. The must-gather tool collects "all", events, configmaps, and secrets [1]. PVC doesn't fall into the category "all".

[1]: https://github.com/openshift/must-gather/blob/9646f4bf643ad8c4201ac8dd7073e7294c90df20/pkg/cmd/inspect/namespace.go#L18-L26

Comment 6 Eric Rich 2019-09-05 20:08:37 UTC
(In reply to Oleg Bulatov from comment #4)
> As I can see, it's not sufficient. The must-gather tool collects "all",
> events, configmaps, and secrets [1]. PVC doesn't fall into the category
> "all".
> 
> [1]:
> https://github.com/openshift/must-gather/blob/
> 9646f4bf643ad8c4201ac8dd7073e7294c90df20/pkg/cmd/inspect/namespace.go#L18-L26

Why would we not just add PVC's to what we collect with namespaces? It seems like a fairly simple PR: https://github.com/openshift/must-gather/pull/128 to implement and resolve this issue.
The gather utility already gathers all the other parts (that are cluster scoped) to map storage to applications: https://github.com/openshift/must-gather/blob/master/collection-scripts/gather#L22 haveing this be something we auto collect seems logical to complete the mapping.

Comment 8 Wenjing Zheng 2019-09-12 03:36:33 UTC
[wzheng@openshift-qe core]$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.2.0-0.nightly-2019-09-11-202233   True        False         133m    Cluster version is 4.2.0-0.nightly-2019-09-11-202233
[wzheng@openshift-qe core]$ ls
configmaps  configmaps.yaml  events.yaml  persistentvolumeclaims.yaml  pods.yaml  replicationcontrollers.yaml  secrets  secrets.yaml  serviceaccounts  services  services.yaml
[wzheng@openshift-qe core]$ pwd
/home/wzheng/4.0/must-gather.local.6204421158298724967/quay-io-openshift-release-dev-ocp-v4-0-art-dev-sha256-06f60cc3f5061748de5a152153306a1d6e3692cb4a5e274e82fa0efb7bc3aec4/namespaces/openshift-image-registry/core

Comment 9 errata-xmlrpc 2019-10-16 06:34:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2922

Comment 10 Red Hat Bugzilla 2023-09-14 05:41:06 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days