Bug 1738483

Summary: libvirt-5.6.0/src/security/security_util.c:271: possible bad test ?
Product: [Community] Virtualization Tools Reporter: David Binderman <dcb314>
Component: libvirtAssignee: Erik Skultety <eskultet>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: eskultet, libvirt-maint, mprivozn, tburke
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-5.7.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-07 10:14:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2019-08-07 09:58:42 UTC 
libvirt-5.6.0/src/security/security_util.c:271]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is


   if (!(ref_name = virSecurityGetRefCountAttrName(name)) |
        !(attr_name = virSecurityGetAttrName(name)))

Maybe better code:

   if (!(ref_name = virSecurityGetRefCountAttrName(name)) ||
        !(attr_name = virSecurityGetAttrName(name)))
Comment 1 Erik Skultety 2019-08-07 10:14:08 UTC 
Fixed upstream by:

commit 5801ef06ec29fdbac6718e455015450f7c243c1b
Refs: v5.6.0-53-g5801ef06ec
Author:     Erik Skultety <eskultet>
AuthorDate: Wed Aug 7 12:08:46 2019 +0200
Commit:     Erik Skultety <eskultet>
CommitDate: Wed Aug 7 12:08:46 2019 +0200

    src: security: Replace bitwise OR with logical OR

    Typo introduced by commit d73f3f58360.

    https://bugzilla.redhat.com/show_bug.cgi?id=1738483

    Signed-off-by: Erik Skultety <eskultet>