Bug 1738483 - libvirt-5.6.0/src/security/security_util.c:271: possible bad test ?
Summary: libvirt-5.6.0/src/security/security_util.c:271: possible bad test ?
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Erik Skultety
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-07 09:58 UTC by David Binderman
Modified: 2019-08-07 12:11 UTC (History)
4 users (show)

Fixed In Version: libvirt-5.7.0
Clone Of:
Environment:
Last Closed: 2019-08-07 10:14:08 UTC
Embargoed:

Attachments (Terms of Use)

Description David Binderman 2019-08-07 09:58:42 UTC 
libvirt-5.6.0/src/security/security_util.c:271]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is


   if (!(ref_name = virSecurityGetRefCountAttrName(name)) |
        !(attr_name = virSecurityGetAttrName(name)))

Maybe better code:

   if (!(ref_name = virSecurityGetRefCountAttrName(name)) ||
        !(attr_name = virSecurityGetAttrName(name)))
Comment 1 Erik Skultety 2019-08-07 10:14:08 UTC 
Fixed upstream by:

commit 5801ef06ec29fdbac6718e455015450f7c243c1b
Refs: v5.6.0-53-g5801ef06ec
Author:     Erik Skultety <eskultet>
AuthorDate: Wed Aug 7 12:08:46 2019 +0200
Commit:     Erik Skultety <eskultet>
CommitDate: Wed Aug 7 12:08:46 2019 +0200

    src: security: Replace bitwise OR with logical OR

    Typo introduced by commit d73f3f58360.

    https://bugzilla.redhat.com/show_bug.cgi?id=1738483

    Signed-off-by: Erik Skultety <eskultet>
Note You need to log in before you can comment on or make changes to this bug.