Bug 1738502

Summary: LVM cache feature not possible with ansible-2.8
Product: [oVirt] cockpit-ovirt Reporter: Gobinda Das <godas>
Component: gluster-ansibleAssignee: Gobinda Das <godas>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: high Docs Contact:
Priority: unspecified    
Version: 0.13.0CC: bugs, godas, rhs-bugs, sabose, sasundar
Target Milestone: ovirt-4.3.6Keywords: ZStream
Target Release: 0.13.6Flags: sbonazzo: ovirt-4.3?
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.13.6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1734778 Environment:
Last Closed: 2019-09-26 19:43:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1734778    

Description Gobinda Das 2019-08-07 10:50:17 UTC 
Description of problem:
-----------------------
With Ansible-2.8, LV cache feature is not working.

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHV 4.3.5
Ansible-2.8.3

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. During deployment enable LV cache. with cache data disk as value


Actual results:
---------------
Failed to setup LV cache

Expected results:
-----------------
LV cache should be setup successfully


Additional info:
----------------
This issue is also reported by oVirt community user using Ansible-2.8
https://bugzilla.redhat.com/show_bug.cgi?id=1720261

Sachi is aware of this issue and has upstream issue - https://github.com/ansible/ansible/issues/56501 - opened for the same

--- Additional comment from SATHEESARAN on 2019-07-31 12:18:13 UTC ---

As a workaround for this issue, Sachi has suggested to have the disk in the VG also as input along with cache disk

<snip>
Now since version 2.8 the behavior has changed, where all the existing pvs which which were part of volume group has to be provided. Like:

- name: Extend volume group
  lvg:
     state: present
     vg: foo_vg
     pvs: "/dev/sdb,/dev/sdc"
     pv_options: "--dataalignment 256K"
</snip>

--- Additional comment from SATHEESARAN on 2019-07-31 12:22:03 UTC ---

Gobinda already has a patch that settles the issue[1] where the LV cache will be attached to the
specific thinpool, along with that patch, it will be easily deducible to find the PV of the VG.

With that information, ansible vars file could be having both the disks PV of that VG, and also the cache disk

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1721451
Comment 1 SATHEESARAN 2019-09-03 05:13:36 UTC 
Verified with cockpit-ovirt-dashboard-0.13.6
LVM cache code takes care of the problem now.

When the cache is created on 'sdc' to cache the contents of thinpool on 'sdb',
then the cache value in the generated vars file becomes - '/dev/sdb,/dev/sdc' as per expectation
Comment 2 Sandro Bonazzola 2019-09-26 19:43:10 UTC 
This bugzilla is included in oVirt 4.3.6 release, published on September 26th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.6 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.