Bug 1740044

Summary:	ClusterOperator operator-lifecycle-manager/operator-lifecycle-manager-catalog missing ClusterStatusConditionType: Upgradeable
Product:	OpenShift Container Platform	Reporter:	Jian Zhang <jiazha>
Component:	OLM	Assignee:	Evan Cordell <ecordell>
OLM sub component:	OLM	QA Contact:	Jian Zhang <jiazha>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	bandrade, chuo, ecordell, jfan, scuppett
Version:	4.1.z
Target Milestone:	---
Target Release:	4.1.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-10 15:59:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1727042
Bug Blocks:

Description Jian Zhang 2019-08-12 07:49:36 UTC

Description of problem:
This bug is a clone of bug 1727032, 1727042. We also should fix it in 4.1.z version.


Version-Release number of selected component (if applicable):
Cluster version is 4.1.10
OLM version:
               io.openshift.build.commit.url=https://github.com/operator-framework/operator-lifecycle-manager/commit/b45dae333aa3d6e4baa8fb8625eac5d7700c6525
               io.openshift.build.source-location=https://github.com/operator-framework/operator-lifecycle-manager

How reproducible:
always

Steps to Reproduce:
1. Install the 4.1.z cluster.
2. Check the ClucsterOperator: operator-lifecycle-manager and operator-lifecycle-manager-catalog fields.

Actual results:
Both of them lack the `Upgradeable` field, which defined in https://github.com/openshift/api/blob/master/config/v1/types_cluster_operator.go#L140

mac:~ jianzhang$ oc get co operator-lifecycle-manager -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2019-08-12T06:42:00Z"
  generation: 1
  name: operator-lifecycle-manager
  resourceVersion: "9130"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager
  uid: 49b30061-bccc-11e9-8add-02ca0e9e91b6
spec: {}
status:
  conditions:
  - lastTransitionTime: "2019-08-12T06:41:59Z"
    status: "False"
    type: Degraded
  - lastTransitionTime: "2019-08-12T06:47:05Z"
    message: Deployed 0.9.0
    status: "False"
    type: Progressing
  - lastTransitionTime: "2019-08-12T06:41:59Z"
    status: "True"
    type: Available
  extension: null
  versions:
  - name: operator
    version: 4.1.10
  - name: operator-lifecycle-manager
    version: 0.9.0

mac:~ jianzhang$ oc get co operator-lifecycle-manager-catalog  -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2019-08-12T06:42:00Z"
  generation: 1
  name: operator-lifecycle-manager-catalog
  resourceVersion: "9120"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager-catalog
  uid: 49a162c3-bccc-11e9-8add-02ca0e9e91b6
spec: {}
status:
  conditions:
  - lastTransitionTime: "2019-08-12T06:41:59Z"
    status: "False"
    type: Degraded
  - lastTransitionTime: "2019-08-12T06:47:04Z"
    message: Deployed 0.9.0
    status: "False"
    type: Progressing
  - lastTransitionTime: "2019-08-12T06:41:59Z"
    status: "True"
    type: Available
  extension: null
  versions:
  - name: operator
    version: 4.1.10
  - name: operator-lifecycle-manager
    version: 0.9.0


Expected results:
Both of them should use the `Upgradeable` field.

Additional info:

Comment 1 Evan Cordell 2019-08-12 15:33:00 UTC

https://github.com/operator-framework/operator-lifecycle-manager/pull/979

Comment 3 Stephen Cuppett 2019-08-27 11:29:00 UTC

Merged. Had a non-direct linked BZ1727042.

Comment 5 Jian Zhang 2019-08-28 06:01:36 UTC

OLM version: io.openshift.build.commit.url=https://github.com/operator-framework/operator-lifecycle-manager/commit/76940550adb7c874dc08cdae838c67b3eb719c03
Cluster version is 4.1.0-0.nightly-2019-08-27-070548

Now, both the "operator-lifecycle-manager" and "operator-lifecycle-manager" have the "Upgradeable" field, LGTM, verify it.
mac:~ jianzhang$ oc get co operator-lifecycle-manager -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2019-08-28T03:17:16Z"
  generation: 1
  name: operator-lifecycle-manager
  resourceVersion: "10008"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager
  uid: 5674a11f-c942-11e9-ae17-02e88bf7619c
spec: {}
status:
  conditions:
  - lastTransitionTime: "2019-08-28T03:17:16Z"
    status: "False"
    type: Degraded
  - lastTransitionTime: "2019-08-28T03:22:21Z"
    message: Deployed 0.9.0
    status: "False"
    type: Progressing
  - lastTransitionTime: "2019-08-28T03:17:16Z"
    status: "True"
    type: Available
  - lastTransitionTime: "2019-08-28T03:17:16Z"
    status: "True"
    type: Upgradeable
  extension: null
  versions:
  - name: operator
    version: 4.1.0-0.nightly-2019-08-27-070548
  - name: operator-lifecycle-manager
    version: 0.9.0
mac:~ jianzhang$ oc get co operator-lifecycle-manager-catalog -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: "2019-08-28T03:17:16Z"
  generation: 1
  name: operator-lifecycle-manager-catalog
  resourceVersion: "10007"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/operator-lifecycle-manager-catalog
  uid: 5674c0f6-c942-11e9-ae17-02e88bf7619c
spec: {}
status:
  conditions:
  - lastTransitionTime: "2019-08-28T03:17:16Z"
    status: "False"
    type: Degraded
  - lastTransitionTime: "2019-08-28T03:22:21Z"
    message: Deployed 0.9.0
    status: "False"
    type: Progressing
  - lastTransitionTime: "2019-08-28T03:17:16Z"
    status: "True"
    type: Available
  - lastTransitionTime: "2019-08-28T03:17:16Z"
    status: "True"
    type: Upgradeable
  extension: null
  versions:
  - name: operator
    version: 4.1.0-0.nightly-2019-08-27-070548
  - name: operator-lifecycle-manager
    version: 0.9.0

Comment 6 Jian Zhang 2019-08-28 06:03:37 UTC

*** Bug 1743748 has been marked as a duplicate of this bug. ***

Comment 8 errata-xmlrpc 2019-09-10 15:59:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2594