Bug 1744557

Based on above moving to RHV

which operation fail? on the snapshot or vm? i suppose the VM does not have a custom copat level of 3.6 but the snapshot may?

*** Bug 1752732 has been marked as a duplicate of this bug. ***

This is the flow:
- The API gets a request to get a snapshot.
- The snapshot is retrieved from the DB, but the API result also needs a VM configuration.
- GetVmConfigurationBySnapshotQuery is called, which gets the VM from DB and applies the OVF configuration changes to it
- The VM config contains fields that are calculated using the config values: maximum memory size, resume behavior

Maybe it is not needed to consider the VM version for these values and just use values from OVF.

I'd say that we should revise why we do autoSelectResumeBehavior() - we should do that only when not set already, no? now it's being always called.

for maxmemory - I think the code is there to fix up invalid mem values in snapshots...shouldn't really be needed - at least when the definition no longer exists. I'd use the current lowest supported version if that's easy to query.

The current patch temporarily sets the custom compatibility version to the lowest supported.

Ok, I will look into why we use autoSelectResumeBehavior() there.

The master patches are merged. Do we want to backport this to 4.3?

I'll clone

WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops

WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops

WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops

WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops

WARN: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{}', ]

For more info please contact: rhv-devops

Verified with:
- RHV 4.4.0-0.32.master.el8ev
- libvirt-6.0.0-17.module+el8.2.0+6257+0d066c28.x86_64
- vdsm-4.40.13-1.el8ev.x86_64

Verification steps:
1. On a RHV 4.2 instance: create a DC, Cluster, Host, and SD with compatibility-version = 3.6
2. Create a VM and make sure the compatibility-version is set with 3.6
3. Create a snapshot and make sure the snapshot is available by https://<engine>/ovirt-engine/api/vms/<vm_uuid>/snapshots
4. Export the VM to export-domain and import the VM on a RHV 4.4 environment
5. Make sure the snapshot is available on the RHV 4.4 environment by https://<engine>/ovirt-engine/api/vms/<vm_uuid>/snapshots

Result:
- The snapshot is accessible on the RHV 4.4 environment by https://<engine>/ovirt-engine/api/vms/<vm_uuid>/snapshots

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3247