Bug 1755869

Based on above moving to RHV

(Originally by Martin Perina)

which operation fail? on the snapshot or vm? i suppose the VM does not have a custom copat level of 3.6 but the snapshot may?

(Originally by michal.skrivanek)

*** Bug 1752732 has been marked as a duplicate of this bug. ***

(Originally by Martin Perina)

This is the flow:
- The API gets a request to get a snapshot.
- The snapshot is retrieved from the DB, but the API result also needs a VM configuration.
- GetVmConfigurationBySnapshotQuery is called, which gets the VM from DB and applies the OVF configuration changes to it
- The VM config contains fields that are calculated using the config values: maximum memory size, resume behavior

Maybe it is not needed to consider the VM version for these values and just use values from OVF.

(Originally by Andrej Krejcir)

I'd say that we should revise why we do autoSelectResumeBehavior() - we should do that only when not set already, no? now it's being always called.

for maxmemory - I think the code is there to fix up invalid mem values in snapshots...shouldn't really be needed - at least when the definition no longer exists. I'd use the current lowest supported version if that's easy to query.

(Originally by michal.skrivanek)

The current patch temporarily sets the custom compatibility version to the lowest supported.

Ok, I will look into why we use autoSelectResumeBehavior() there.

(Originally by Andrej Krejcir)

The master patches are merged. Do we want to backport this to 4.3?

(Originally by Andrej Krejcir)

I'll clone

(Originally by Ryan Barry)

WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.3.z': '?'}', ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.3.z': '?'}', ]

For more info please contact: rhv-devops

INFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Tag 'ovirt-engine-4.3.7.1' doesn't contain patch 'https://gerrit.ovirt.org/103510']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.3.7.1

For more info please contact: rhv-devops

INFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Tag 'ovirt-engine-4.3.7.2' doesn't contain patch 'https://gerrit.ovirt.org/103510']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.3.7.2

For more info please contact: rhv-devops

Verification steps:

- Install RHV 4.2.8.7-0.1.el7ev
- Set DC and Cluster compatibility-version to 3.6
- Add host and storage domain
- Create VM with compatibility-version set for 3.6
- Create VM snapshot
- Update the VM, Cluster and DC to compatibility-version 4.1
- Upgrade RHV 4.2.8.7-0.1.el7ev to 4.3.7.2-0.1.el7
- Access snapshots by API https://<engine>/ovirt-engine/api/vms/<vm_uuid>/snapshots

Result:

- The snapshot information accessible by API (and it's possible to start the vm).

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4229