Bug 1755869 - [downstream clone - 4.3.6] RHV 4.3 throws an exception when trying to access VMs which have snapshots from unsupported compatibility levels
Summary: [downstream clone - 4.3.6] RHV 4.3 throws an exception when trying to access ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.3.0
Hardware: All
OS: All
medium
high
Target Milestone: ovirt-4.3.7
: 4.3.6
Assignee: Andrej Krejcir
QA Contact: Beni Pelled
URL:
Whiteboard:
Depends On: 1744557
Blocks: 1752732
TreeView+ depends on / blocked
 
Reported: 2019-09-26 11:13 UTC by RHV bug bot
Modified: 2023-03-24 15:31 UTC (History)
11 users (show)

Fixed In Version: ovirt-engine-4.3.6.7
Doc Type: No Doc Update
Doc Text:
Clone Of: 1744557
Environment:
Last Closed: 2019-12-12 10:36:35 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:
lsvaty: testing_plan_complete-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:4229 0 None None None 2019-12-12 10:36:54 UTC
oVirt gerrit 103510 0 'None' MERGED core: Do not call DB in SnapshotVmConfigurationHelper#getVmFromConfiguration 2020-08-04 13:49:43 UTC
oVirt gerrit 103511 0 'None' MERGED core: Getting snapshot with unsupported version does not fail 2020-08-04 13:49:43 UTC
oVirt gerrit 103591 0 'None' MERGED core: Getting snapshot with unsupported version does not fail 2020-08-04 13:49:43 UTC

Comment 18 RHV bug bot 2019-09-26 11:15:42 UTC
Based on above moving to RHV

(Originally by Martin Perina)

Comment 21 RHV bug bot 2019-09-26 11:15:48 UTC
which operation fail? on the snapshot or vm? i suppose the VM does not have a custom copat level of 3.6 but the snapshot may?

(Originally by michal.skrivanek)

Comment 24 RHV bug bot 2019-09-26 11:15:54 UTC
*** Bug 1752732 has been marked as a duplicate of this bug. ***

(Originally by Martin Perina)

Comment 29 RHV bug bot 2019-09-26 11:16:03 UTC
This is the flow:
- The API gets a request to get a snapshot.
- The snapshot is retrieved from the DB, but the API result also needs a VM configuration.
- GetVmConfigurationBySnapshotQuery is called, which gets the VM from DB and applies the OVF configuration changes to it
- The VM config contains fields that are calculated using the config values: maximum memory size, resume behavior

Maybe it is not needed to consider the VM version for these values and just use values from OVF.

(Originally by Andrej Krejcir)

Comment 30 RHV bug bot 2019-09-26 11:16:04 UTC
I'd say that we should revise why we do autoSelectResumeBehavior() - we should do that only when not set already, no? now it's being always called.

for maxmemory - I think the code is there to fix up invalid mem values in snapshots...shouldn't really be needed - at least when the definition no longer exists. I'd use the current lowest supported version if that's easy to query.

(Originally by michal.skrivanek)

Comment 31 RHV bug bot 2019-09-26 11:16:06 UTC
The current patch temporarily sets the custom compatibility version to the lowest supported.

Ok, I will look into why we use autoSelectResumeBehavior() there.

(Originally by Andrej Krejcir)

Comment 32 RHV bug bot 2019-09-26 11:16:08 UTC
The master patches are merged. Do we want to backport this to 4.3?

(Originally by Andrej Krejcir)

Comment 33 RHV bug bot 2019-09-26 11:16:10 UTC
I'll clone

(Originally by Ryan Barry)

Comment 35 RHV bug bot 2019-10-24 16:33:55 UTC
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.3.z': '?'}', ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.3.z': '?'}', ]

For more info please contact: rhv-devops

Comment 36 RHV bug bot 2019-11-01 09:32:01 UTC
INFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Tag 'ovirt-engine-4.3.7.1' doesn't contain patch 'https://gerrit.ovirt.org/103510']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.3.7.1

For more info please contact: rhv-devops

Comment 37 RHV bug bot 2019-11-14 11:10:05 UTC
INFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Tag 'ovirt-engine-4.3.7.2' doesn't contain patch 'https://gerrit.ovirt.org/103510']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.3.7.2

For more info please contact: rhv-devops

Comment 38 Beni Pelled 2019-11-18 15:49:01 UTC
Verification steps:

- Install RHV 4.2.8.7-0.1.el7ev
- Set DC and Cluster compatibility-version to 3.6
- Add host and storage domain
- Create VM with compatibility-version set for 3.6
- Create VM snapshot
- Update the VM, Cluster and DC to compatibility-version 4.1
- Upgrade RHV 4.2.8.7-0.1.el7ev to 4.3.7.2-0.1.el7
- Access snapshots by API https://<engine>/ovirt-engine/api/vms/<vm_uuid>/snapshots

Result:

- The snapshot information accessible by API (and it's possible to start the vm).

Comment 40 errata-xmlrpc 2019-12-12 10:36:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4229


Note You need to log in before you can comment on or make changes to this bug.