Bug 1747179

Summary: [Regression] [ActionView::Template::Error] undefined method `tenant_group?' while setting ownership for key pairs
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Matouš Mojžíš <mmojzis>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.11.0CC: bmidwood, dmetzger, hkataria, lavenel, mmojzis, mpovolny, obarenbo, simaishi, smallamp
Target Milestone: GAKeywords: Regression, ZStream
Target Release: 5.11.1Flags: simaishi: cfme-5.11.z+
mfeifer: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-13 00:35:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1730066    

Description Nandini Chandra 2019-08-29 20:08:41 UTC 
Description of problem:
-----------------------
The UI blows up with this error while setting ownership for key pairs.

[----] F, [2019-08-29T15:45:12.087274 #7957:2ac80adb88d0] FATAL -- : Error caught: [ActionView::Template::Error] undefined method `tenant_group?' for nil:NilClass
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-6bdbde5fee2b/app/views/shared/views/_ownership.html.haml:11:in `__opt_rh_cfme_gemset_bundler_gems_cfme_ui_classic__bdbde_fee_b_app_views_shared_views__ownership_html_haml__1099713222378496976_47038845899600'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/template.rb:157:in `block in render'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:168:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/template.rb:352:in `instrument_render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/template.rb:155:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/partial_renderer.rb:342:in `block in render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/partial_renderer.rb:331:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/renderer.rb:21:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/helpers/rendering_helper.rb:31:in `render'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-6bdbde5fee2b/app/views/auth_key_pair_cloud/show.html.haml:4:in `__opt_rh_cfme_gemset_bundler_gems_cfme_ui_classic__bdbde_fee_b_app_views_auth_key_pair_cloud_show_html_haml__3926788001676406739_47038755367040'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/template.rb:157:in `block in render'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:168:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/template.rb:352:in `instrument_render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/template.rb:155:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/template_renderer.rb:52:in `block (2 levels) in render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.1.7/lib/active_support/notifications.rb:166:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/template_renderer.rb:51:in `block in render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/template_renderer.rb:59:in `render_with_layout'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/template_renderer.rb:50:in `render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/template_renderer.rb:14:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/renderer.rb:42:in `render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/renderer/renderer.rb:23:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/rendering.rb:103:in `_render_template'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/streaming.rb:217:in `_render_template'
/opt/rh/cfme-gemset/gems/actionview-5.1.7/lib/action_view/rendering.rb:83:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/renderers.rb:141:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/abstract_controller/rendering.rb:24:in `render'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/rendering.rb:36:in `render'
/opt/rh/cfme-gemset/gems/actionpack-5.1.7/lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render'



Version-Release number of selected component (if applicable):
-------------------------------------------------------------
5.11.0.21


How reproducible:
----------------
Always


Steps to Reproduce:
------------------
1.Manage a cloud provider with key pairs, eg: ec2 .
2.Navigate to Compute -> Cloud -> key pairs
3.Click Configuration -> Set ownership


Actual results:
---------------
The UI blows up while setting ownership for key pairs.


Expected results:
-----------------
It should be possible to set ownership for key pairs.


Additional info:
---------------
Please see https://bugzilla.redhat.com/show_bug.cgi?id=1730066 .

The ability to set ownership for key pairs was incorporated through the above BZ.
Comment 2 Nandini Chandra 2019-08-29 20:15:39 UTC 
This issue is not seen in 5.10.9.1 .
Comment 3 Nandini Chandra 2019-08-29 20:47:04 UTC 
This BZ should be a blocker for 5.11 since it  blocks the verification of a customer reported BZ.

https://bugzilla.redhat.com/show_bug.cgi?id=1730066
Comment 4 Harpreet Kataria 2019-08-29 20:57:32 UTC 
This issue was fixed on upstream by changes in https://github.com/ManageIQ/manageiq-ui-classic/pull/5863. Will need to be create a Ivanchuk specific fix

~Harpreet
Comment 5 Harpreet Kataria 2019-08-29 21:11:02 UTC 
IVANCHUK PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/6133
Comment 6 Nandini Chandra 2019-09-06 19:14:39 UTC 
The verification of a customer reported regression bug[0] is blocked by this bug. Could this be marked as a blocker for 511 ?

[0]https://bugzilla.redhat.com/show_bug.cgi?id=1730066
Comment 10 CFME Bot 2019-11-01 19:28:37 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/cdfe39b65e5b04f92af54b8a9e1bb422f3b1fb92
commit cdfe39b65e5b04f92af54b8a9e1bb422f3b1fb92
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Aug 29 17:07:32 2019 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Aug 29 17:07:32 2019 -0400

    Added a nil check.

    This fixes a `undefined method `tenant_group?' for nil:NilClass` error when selected KeyPair's group didnt exist

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1747179

 app/views/shared/views/_ownership.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 11 Matouš Mojžíš 2019-11-20 15:48:16 UTC 
Verified in 5.11.1.0. Ownership can be set for key pairs without any issues.
Comment 13 errata-xmlrpc 2019-12-13 00:35:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:4201