Bug 174915

Summary:	Review Request: gnome-sudoku - A numerical logic puzzle game
Product:	[Fedora] Fedora	Reporter:	Paul W. Frields <stickster>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://rpm.frields.org/extras-testing/gnome-sudoku/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-12-13 12:48:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Paul W. Frields 2005-12-04 00:26:28 UTC

Spec Name or Url: http://rpm.frields.org/extras-testing/gnome-sudoku/gnome-sudoku.spec
SRPM Name or Url: http://rpm.frields.org/extras-testing/gnome-sudoku/gnome-sudoku-0.3.4-1.src.rpm
Description: A GNOME version of Sudoku, a Japanese numerical logic puzzle game.

Comment 1 John Mahowald 2005-12-11 17:06:44 UTC

- rpmlint is satisfied
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream 
- package compiles on FC4
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file installed
- Works! :)

A note about python's sitelib location: if you follow the python spec template
there's a python_sitelib %define. Works without it though.

APPROVED

Comment 2 Ville Skyttä 2005-12-11 18:23:29 UTC

(In reply to comment #1)
> A note about python's sitelib location: if you follow the python spec template
> there's a python_sitelib %define. Works without it though.

I don't think it works.  This is noarch python stuff, but the specfile uses
%{_libdir}.  That'll break when built on x86_64 (noarch python stuff lives
nowadays always in /usr/lib, not /usr/lib64).  I'd suggest using the python spec
template.

Comment 3 John Mahowald 2005-12-11 22:04:20 UTC

(In reply to comment #2)
> (In reply to comment #1)
> > A note about python's sitelib location: if you follow the python spec template
> > there's a python_sitelib %define. Works without it though.
> 
> I don't think it works.  This is noarch python stuff, but the specfile uses
> %{_libdir}.  That'll break when built on x86_64 (noarch python stuff lives
> nowadays always in /usr/lib, not /usr/lib64).  I'd suggest using the python spec
> template.

Oops, forgot about that. It works on i386, didn't test on others.

Approval is now dependent on making this use python_sitelib instread of _libdir.

Comment 4 Paul W. Frields 2005-12-12 00:30:29 UTC

Redone with fedora-rpmdevtools template, using %python_sitelib.  Build still
works fine and mock and rpmlint are both happy.  Refer to the new spec and SRPM
at:  http://rpm.frields.org/extras-testing/gnome-sudoku/

Thanks Ville, now using the rpmdevtools from now on.

Comment 5 John Mahowald 2005-12-12 02:02:17 UTC

My review in comment 1 still holds.

APPROVED (again)

Comment 6 Christian Iseli 2006-12-31 11:37:56 UTC

Please do not remove the FE-ACCEPT blocker.  Thanks.