Spec Name or Url: http://rpm.frields.org/extras-testing/gnome-sudoku/gnome-sudoku.spec SRPM Name or Url: http://rpm.frields.org/extras-testing/gnome-sudoku/gnome-sudoku-0.3.4-1.src.rpm Description: A GNOME version of Sudoku, a Japanese numerical logic puzzle game.
- rpmlint is satisfied - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible - source matches upstream - package compiles on FC4 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file installed - Works! :) A note about python's sitelib location: if you follow the python spec template there's a python_sitelib %define. Works without it though. APPROVED
(In reply to comment #1) > A note about python's sitelib location: if you follow the python spec template > there's a python_sitelib %define. Works without it though. I don't think it works. This is noarch python stuff, but the specfile uses %{_libdir}. That'll break when built on x86_64 (noarch python stuff lives nowadays always in /usr/lib, not /usr/lib64). I'd suggest using the python spec template.
(In reply to comment #2) > (In reply to comment #1) > > A note about python's sitelib location: if you follow the python spec template > > there's a python_sitelib %define. Works without it though. > > I don't think it works. This is noarch python stuff, but the specfile uses > %{_libdir}. That'll break when built on x86_64 (noarch python stuff lives > nowadays always in /usr/lib, not /usr/lib64). I'd suggest using the python spec > template. Oops, forgot about that. It works on i386, didn't test on others. Approval is now dependent on making this use python_sitelib instread of _libdir.
Redone with fedora-rpmdevtools template, using %python_sitelib. Build still works fine and mock and rpmlint are both happy. Refer to the new spec and SRPM at: http://rpm.frields.org/extras-testing/gnome-sudoku/ Thanks Ville, now using the rpmdevtools from now on.
My review in comment 1 still holds. APPROVED (again)
Please do not remove the FE-ACCEPT blocker. Thanks.