Bug 1749586
| Summary: | Entries on logs screen seem to be missing some styling in Cockpit 202 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> | ||||||
| Component: | cockpit | Assignee: | Matej Marušák <mmarusak> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 31 | CC: | dperpeet, ichavero, mpitt, stefw | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | openqa | ||||||||
| Fixed In Version: | cockpit-202.1-1.fc30 cockpit-202.1-1.fc31 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2019-09-11 03:13:01 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Adam Williamson
2019-09-05 23:19:24 UTC
Created attachment 1612112 [details]
how it looked before
Created attachment 1612113 [details]
how it looks now
This isn't just unlucky styling for small screen sizes, it happens on big screens as well. There were no direct styling changes to the Logs page between 201 and 202, so this must have been some inadvertent side effect of some generic CSS changes, or possibly a new PF or other npm version. Matej, can you please have a look? It may affect other pages too, note - Logs is the first the openQA test checks. It usually checks Services afterwards, bur because Logs fails, that's skipped. Thanks for the report. It is easy to reproduce - just installing cockpit 202 from repos on my normal F30. Also most of these issues I see on master (but I had to clean everything and `make` everything from scratch) I noticed a few broken things: 1. Logs as reported 2. Inlined logs (like in storage or in services) 3. Services list is a bit different 4. Names in storage (like name of volume or drive) is way to big and breaks UI (I cannot reproduce this with master only happens with package) 5. Items in Accounts lost contrast Not just design but functional: 1. On System page graphs show only units but no values (like only showing `MiB/s Disk I/O` and not `40 MiB/s Disk I/O` Ok, so with bisecting I found the culprit: https://github.com/cockpit-project/cockpit/commit/dabebcab33d7a38488338035d7db537984e5ef9a Reverting this commit fixes: > 1. Logs as reported > 2. Inlined logs (like in storage or in services) > 3. Services list is a bit different > 5. Items in Accounts lost contrast Upstream PR: https://github.com/cockpit-project/cockpit/pull/12729 > 4. Names in storage (like name of volume or drive) is way to big and breaks UI (I cannot reproduce this with master only happens with package) I cannot reproduce this locally. I'll try to compare css files from package and locally built > 1. On System page graphs show only units but no values (like only showing `MiB/s Disk I/O` and not `40 MiB/s Disk I/O` Ah, I just realized I was reading this wrong :D This is correct, but since it was a bit mis-styled (fixed in the same PR) it seemed like it should have some additional text. thanks folks, score another point for screenshot-based testing I guess :P This was fixed in today's extracurricular release 202.1. It's a rather huge regression (by our standards, anyway) and quite embarrassing. FEDORA-2019-64cf30d787 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-64cf30d787 FEDORA-2019-3a762c57a9 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3a762c57a9 cockpit-202.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3a762c57a9 cockpit-202.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. cockpit-202.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |