Bug 1749762 (python-rq)

Summary:	Review Request: python-rq - Simple, lightweight, library for creating background jobs, and processing them
Product:	[Fedora] Fedora	Reporter:	Igor Raits <igor.raits>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-06 16:03:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Igor Raits 2019-09-06 11:51:51 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rq.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rq-1.1.0-1.fc32.src.rpm
Description:
RQ (Redis Queue) is a simple Python library for queueing jobs and processing them in the background with workers. It is backed by Redis and it is designed to have a low barrier to entry. It should be integrated in your web stack easily.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2019-09-06 12:09:18 UTC

Taking this review.

Comment 2 Neal Gompa 2019-09-06 12:10:13 UTC

Please pull in the license file as a separate source from the upstream repository or use the GitHub release (instead of PyPI's) to incorporate the license file.

Comment 3 Igor Raits 2019-09-06 12:13:55 UTC

(In reply to Neal Gompa from comment #2)
> Please pull in the license file as a separate source from the upstream
> repository or use the GitHub release (instead of PyPI's) to incorporate the
> license file.

does it really matter? upstream will include it to PyPI in the next release

Comment 4 Neal Gompa 2019-09-06 12:17:23 UTC

(In reply to Igor Gnatenko from comment #3)
> (In reply to Neal Gompa from comment #2)
> > Please pull in the license file as a separate source from the upstream
> > repository or use the GitHub release (instead of PyPI's) to incorporate the
> > license file.
> 
> does it really matter? upstream will include it to PyPI in the next release

Yes, it's especially mandatory for BSD/MIT licensed software, as the terms vary among all the flavors...

Comment 5 Igor Raits 2019-09-06 12:18:50 UTC

New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rq.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rq-1.1.0-1.fc32.src.rpm

Comment 6 Neal Gompa 2019-09-06 12:22:23 UTC

Review notes:
[x]: Package follows Fedora Python Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 7 Gwyn Ciesla 2019-09-06 13:15:47 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rq