Bug 1749762 (python-rq) - Review Request: python-rq - Simple, lightweight, library for creating background jobs, and processing them
Summary: Review Request: python-rq - Simple, lightweight, library for creating backgro...
Keywords:
Status: CLOSED RAWHIDE
Alias: python-rq
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-06 11:51 UTC by Igor Raits
Modified: 2019-09-06 16:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-06 16:03:27 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Igor Raits 2019-09-06 11:51:51 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rq.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rq-1.1.0-1.fc32.src.rpm
Description:
RQ (Redis Queue) is a simple Python library for queueing jobs and processing them in the background with workers. It is backed by Redis and it is designed to have a low barrier to entry. It should be integrated in your web stack easily.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2019-09-06 12:09:18 UTC
Taking this review.

Comment 2 Neal Gompa 2019-09-06 12:10:13 UTC
Please pull in the license file as a separate source from the upstream repository or use the GitHub release (instead of PyPI's) to incorporate the license file.

Comment 3 Igor Raits 2019-09-06 12:13:55 UTC
(In reply to Neal Gompa from comment #2)
> Please pull in the license file as a separate source from the upstream
> repository or use the GitHub release (instead of PyPI's) to incorporate the
> license file.

does it really matter? upstream will include it to PyPI in the next release

Comment 4 Neal Gompa 2019-09-06 12:17:23 UTC
(In reply to Igor Gnatenko from comment #3)
> (In reply to Neal Gompa from comment #2)
> > Please pull in the license file as a separate source from the upstream
> > repository or use the GitHub release (instead of PyPI's) to incorporate the
> > license file.
> 
> does it really matter? upstream will include it to PyPI in the next release

Yes, it's especially mandatory for BSD/MIT licensed software, as the terms vary among all the flavors...

Comment 6 Neal Gompa 2019-09-06 12:22:23 UTC
Review notes:
[x]: Package follows Fedora Python Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

Comment 7 Gwyn Ciesla 2019-09-06 13:15:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rq


Note You need to log in before you can comment on or make changes to this bug.