Bug 1750694
| Summary: | unzip: Please build in C89 mode | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||||
| Component: | unzip | Assignee: | Jakub Martisko <jamartis> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | kdudka, pstodulk, vvitek | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | unzip-6.0-58.fc38 | Doc Type: | Enhancement | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2022-11-09 16:47:19 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2137516 | ||||||||
| Attachments: |
|
||||||||
Porting to C99 is too risky for other targets. I recommend building in C89 mode instead. Created attachment 1918984 [details]
Build with -std=gnu89
Switch GCC to C89 mode.
I verified that this does not trigger any implicitness errors (which are expected to be turned on in GCC 14).
FEDORA-2022-335841c79d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-335841c79d FEDORA-2022-335841c79d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |
Created attachment 1613525 [details] unzip.patch A future version of GCC will default to C99 and reject implicit function declarations. The custom unix/configure script is not able to deal with this and produces incorrect results due to missing function declarations. A start of patch showing the changes required is attached, but further tweaks are needed.