Bug 1750694 - unzip: Please build in C89 mode
Summary: unzip: Please build in C89 mode
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: unzip
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jakub Martisko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCExemptions
TreeView+ depends on / blocked
 
Reported: 2019-09-10 09:30 UTC by Florian Weimer
Modified: 2023-08-16 09:25 UTC (History)
3 users (show)

Fixed In Version: unzip-6.0-58.fc38
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-09 16:47:19 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
unzip.patch (1.84 KB, patch)
2019-09-10 09:30 UTC, Florian Weimer 		no flags Details | Diff
Build with -std=gnu89 (1.63 KB, patch)
2022-10-19 09:05 UTC, Florian Weimer 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 2143565 0 unspecified CLOSED zip: Build in C89 mode 2023-08-17 05:38:03 UTC
Red Hat Issue Tracker FC-924 0 None None None 2023-08-16 09:25:07 UTC

Internal Links: 2143565

Description Florian Weimer 2019-09-10 09:30:52 UTC 
Created attachment 1613525 [details]
unzip.patch

A future version of GCC will default to C99 and reject implicit function declarations. The custom unix/configure script is not able to deal with this and produces incorrect results due to missing function declarations.

A start of patch showing the changes required is attached, but further tweaks are needed.
Comment 1 Florian Weimer 2022-10-19 09:03:02 UTC 
Porting to C99 is too risky for other targets. I recommend building in C89 mode instead.
Comment 2 Florian Weimer 2022-10-19 09:05:20 UTC 
Created attachment 1918984 [details]
Build with -std=gnu89

Switch GCC to C89 mode.

I verified that this does not trigger any implicitness errors (which are expected to be turned on in GCC 14).
Comment 3 Fedora Update System 2022-11-09 16:44:58 UTC 
FEDORA-2022-335841c79d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-335841c79d
Comment 4 Fedora Update System 2022-11-09 16:47:19 UTC 
FEDORA-2022-335841c79d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.