Bug 1751641

Summary:	AllowVolumeExpansion is not set when upgrade from 4.1.z to 4.2
Product:	OpenShift Container Platform	Reporter:	Chao Yang <chaoyang>
Component:	Storage	Assignee:	Christian Huffman <chuffman>
Status:	CLOSED ERRATA	QA Contact:	Chao Yang <chaoyang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	aos-bugs, aos-storage-staff, bbennett, bchilds, cblecker, chuffman
Target Milestone:	---
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1753355 (view as bug list)		Environment:
Last Closed:	2020-01-23 11:05:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1753355

Description Chao Yang 2019-09-12 09:58:58 UTC

Description of problem:
AllowVolumeExpansion is not set when upgrade from 4.1.z to 4.2

Version-Release number of selected component (if applicable):
upgrade from 4.1.z to 4.2

How reproducible:
Always
Steps to Reproduce:
1.After upgrade from 4.1.6 to 4.2, clusteroperator is working
oc get clusteroperator
NAME                                       VERSION                             AVAILABLE   PROGRESSING   DEGRADED   SINCE
authentication                             4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h27m
cloud-credential                           4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h45m
cluster-autoscaler                         4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h45m
console                                    4.2.0-0.nightly-2019-09-12-034447   True        False         False      41m
dns                                        4.1.15                              True        False         False      3h44m
image-registry                             4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h36m
ingress                                    4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h37m
insights                                   4.2.0-0.nightly-2019-09-12-034447   True        False         False      44m
kube-apiserver                             4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h42m
kube-controller-manager                    4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h44m
kube-scheduler                             4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h43m
machine-api                                4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h45m
machine-config                             4.1.15                              True        False         False      3h44m
marketplace                                4.1.15                              False       True          False      44m
monitoring                                 4.2.0-0.nightly-2019-09-12-034447   True        False         False      42m
network                                    4.1.15                              True        False         False      3h45m
node-tuning                                4.2.0-0.nightly-2019-09-12-034447   True        False         False      43m
openshift-apiserver                        4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h41m
openshift-controller-manager               4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h44m
openshift-samples                          4.2.0-0.nightly-2019-09-12-034447   True        False         False      44m
operator-lifecycle-manager                 4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h44m
operator-lifecycle-manager-catalog         4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h44m
operator-lifecycle-manager-packageserver   4.2.0-0.nightly-2019-09-12-034447   True        False         False      41m
service-ca                                 4.2.0-0.nightly-2019-09-12-034447   True        False         False      3h45m
service-catalog-apiserver                  4.2.0-0.nightly-2019-09-12-034447   True        False         False      105m
service-catalog-controller-manager         4.2.0-0.nightly-2019-09-12-034447   True        False         False      105m
storage                                    4.2.0-0.nightly-2019-09-12-034447   True        False         False      44m

2.Check storage class
oc describe sc
Name:                  gp2
IsDefaultClass:        Yes
Annotations:           storageclass.kubernetes.io/is-default-class=true
Provisioner:           kubernetes.io/aws-ebs
Parameters:            encrypted=true,type=gp2
AllowVolumeExpansion:  <unset>
MountOptions:          <none>
ReclaimPolicy:         Delete
VolumeBindingMode:     WaitForFirstConsumer
Events:                <none>


Actual results:
AllowVolumeExpansion is not set

Expected results:
AllowVolumeExpansion should be true
Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 1 Christian Huffman 2019-09-12 18:04:36 UTC

I created https://github.com/openshift/cluster-storage-operator/pull/47 to address this issue. It examines the existing SC created from the assets file, and if changes are found in AllowVolumeExpansion or MountOptions these are applied to the existing SC.

Comment 2 Christian Huffman 2019-09-18 15:14:08 UTC

For 4.2 this is being addressed via the documented in bug 1753311 . Moving this to target release 4.3.

Comment 7 Chao Yang 2019-10-09 01:49:07 UTC

Will test this in 4.3.

Comment 8 Chao Yang 2019-11-14 05:59:34 UTC

Verification is passed.
upgrade server from 4.1.0-0.nightly-2019-11-12-234353 to 4.3.0-0.nightly-2019-11-13-233341

Comment 10 errata-xmlrpc 2020-01-23 11:05:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062