Bug 175168

* no desktop menu entry included, although this is a GUI program

* menu "New Window" gives error message:

  Information
  'New Window' action failed: Failed to execute child process
  'gideon' (No such file or directory)
   spawn_async(/home/qa, gideon)

The 'New Window' bug was fixed in R6 apparently.

About the desktop entry: the upstream project does not provide any sort of icon
that i could use here. Should we skip the desktop menu entry, or provide some
default icon ?

(In reply to comment #2)
> The 'New Window' bug was fixed in R6 apparently.
> 
> About the desktop entry: the upstream project does not provide any sort of icon
> that i could use here. Should we skip the desktop menu entry, or provide some
> default icon ?
> 

A desktop entry is mandated by the packaging guidelines. I suggest you create a
.desktop file as a patch and push this change upstream. 

(In reply to comment #2)
> About the desktop entry: the upstream project does not provide any sort of icon
> that i could use here. Should we skip the desktop menu entry, or provide some
> default icon ?

A desktop menu entry without an icon is better than no desktop entry at all. 
Don't let that prevent you from providing a desktop entry.

If upstream doesn't have an official logo then you might try taking a look at
the various images used by the application and see if anything would be
appropriate for an unofficial logo.  You'll probably have to manually convert it
to the appropriate size/format.

In any case, you should definitely bug upstream to provide both of these.

http://www.poolshark.org/src/gideon-R6-0.1.BETA.src.rpm
http://www.poolshark.org/src/gideon.spec

- Update to R6 (New Window problem fixed)
- Added desktop entry. Currently no official icon, and the app doesn't use any
suitable images. Problem submitted and acknowledged upstream.
- Clean mock build and rpmlint

Better is to use http://dl.sourceforge.net/gideon/gideon-%{version}.BETA.tar.bz2
as Source0 in the spec. It doesn't depend on the existence of one specific SF
mirror.

Fixed.

http://www.poolshark.org/src/gideon-R6-0.2.BETA.src.rpm
http://www.poolshark.org/src/gideon.spec

Update.

http://www.poolshark.org/src/gideon-R8-0.1.BETA.src.rpm
http://www.poolshark.org/src/gideon.spec

An unofficial review.
1. It looks like the URL has changed.
2. Using %makeinstall is discouraged. 

see http://fedoraproject.org/wiki/Packaging/Guidelines

Fixed.

http://www.poolshark.org/src/gideon-R8-0.2.BETA.src.rpm
http://www.poolshark.org/src/gideon.spec

MUST Items: Good
SHOULD Items: Good

Everything seems fine except Michael, which is assigned to this package, must
approve the package.  Unofficially it follows all the guidelines.  Tested on
x86_64 without problems.

One thing I've waited for has happened:

* On July 3rd, the author released: gideon-2.7.0.tar.bz2

This gets rid of the unusual versioning scheme. Fortunately,
"2 > R". [Previously, the author sounded as if he would continue
using "Rx" release names.]

The new release also breaks the ABI.

Gosh, and now they release 3 tarballs instead of one. I need to check with
upstream what is to be done wrt packaging (all 3 are released under the same
version number but I'm guessing that won't always be the case). I can't say I'm
thrilled at the idea of having to split this review into 3 different ones...
(gideon, gideon-guiloader and gideon-guiloader-c++)...

http://www.poolshark.org/src/gideon-2.8.0-1.src.rpm
http://www.poolshark.org/src/gideon.spec

Packaging-wise it's only missing "Requires: pkgconfig" in the -devel
package.

Although it loads quickly, it could be enhanced with startup notification
in the desktop file.

At run-time, I stumbled into a NULL-pointer related segfault in
"Save As" while building a tiny test-GUI. It was too easy to make it
crash, but not reproducible afterwards.

Anyway, after a crash, I feel approval would be premature, so somebody
else would need to take over in order to accept v2.8.0 as is.

http://www.poolshark.org/src/gideon-2.8.0-2.src.rpm
http://www.poolshark.org/src/gideon.spec

> Packaging-wise it's only missing "Requires: pkgconfig" in the -devel
> package.

Fixed.

> Although it loads quickly, it could be enhanced with startup notification
> in the desktop file.

Fixed.

I also added a Mime xml file so that gui xml files are opened by gideon correctly.

I spent an hour this morning playing with the Gui designer to try to reproduce
your Save As crash, but no luck. Do you remember what type of widgets you were
using ? Do you really feel this bug should prevent gideon from being in FE ? It
will be difficult to iron out the remaining bugs if the only 2 people testing it
are you and me :-)

The project was renamed to crow, or 'Crow Designer'. Plus 2.8.1 update.

http://www.poolshark.org/src/crow.spec
http://www.poolshark.org/src/crow-2.8.1-1.src.rpm

You might want to reconsider the decision to include this package into Fedora
Extras. Development on this project has been abandoned.

http://mail.gnome.org/archives/desktop-devel-list/2006-October/msg00474.html

Gosh, thanks for pointing me to the thread. I'm not on the gnome mailing list
and didn't know about this. Nothing of it was mentioned on the Gideon google
group which i'm subscribed to...

I think you're right, which is a shame because i like this tool from the start
and it has reached a pretty stable point. I'll wait a few weeks to see if
someone picks up the project...

Closing. Looks like upstream is truly dead. Sad.

Marking as bug #201449