Bug 1751846

Thanks! Looking at this now!

Spec URL (updated): https://major.fedorapeople.org/python-neurodsp.spec

Looks pretty good.  A few minor issues to be corrected:

- Please add a changelog
- Please include the bits in the `paper` directory in the %doc---they contain
  the citations, so it's good to ship them in the rpm also.
- Similary, please include the `examples` and `tutorials `directory in %doc
  too. This will probably require a new -doc sub package, since the doc size
  will increase.
- Cosmetic suggestion: consider using standardised Requires/BuildRequires:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_requires_and_buildrequires_with_standardized_names
I.e., replace python3-numpy with %{py3_dist numpy}


- Tests have not run. Looks like python3 setup.py test doesn't call them.
  Please try pyest-3 instead.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
^
Missing, please add before import :)

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Package functions as described.
^ Not sure here---tests did not run

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
^ Do you want to give this a go? Newly added to the guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_verifying_signatures

[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
^
I looked at the build log. Looks like python setup.py doesn't run the tests.
Please try: pytest-3 instead.

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-neurodsp-2.0.0-1.fc32.noarch.rpm
          python-neurodsp-2.0.0-1.fc32.src.rpm
python3-neurodsp.noarch: W: summary-ended-with-dot C A tool for digital signal processing for neural time series.
^
Please remove the dot at end of summary

python3-neurodsp.noarch: W: spelling-error %description -l en_US bandpass -> band pass, band-pass, bandannas
python3-neurodsp.noarch: W: spelling-error %description -l en_US highpass -> high pass, high-pass, highness
python3-neurodsp.noarch: W: spelling-error %description -l en_US lowpass -> low pass, low-pass, lowness
python3-neurodsp.noarch: W: spelling-error %description -l en_US aperiodic -> periodic, a periodic, DiCaprio
^
Ignore these

python3-neurodsp.noarch: E: no-changelogname-tag
^
Missing changelog

python-neurodsp.src: W: summary-ended-with-dot C A tool for digital signal processing for neural time series.
python-neurodsp.src: W: spelling-error %description -l en_US filt -> flit, lift, gilt
python-neurodsp.src: W: spelling-error %description -l en_US bandpass -> band pass, band-pass, bandannas
python-neurodsp.src: W: spelling-error %description -l en_US highpass -> high pass, high-pass, highness
python-neurodsp.src: W: spelling-error %description -l en_US lowpass -> low pass, low-pass, lowness
python-neurodsp.src: W: spelling-error %description -l en_US timefrequency -> time frequency, time-frequency, frequency
python-neurodsp.src: W: spelling-error %description -l en_US sim -> seem, ism, aim
python-neurodsp.src: W: spelling-error %description -l en_US aperiodic -> periodic, a periodic, DiCaprio
python-neurodsp.src: W: spelling-error %description -l en_US plts -> pelts, plats, plots
python-neurodsp.src: E: no-changelogname-tag
2 packages and 0 specfiles checked; 2 errors, 14 warnings.




Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_GB.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_GB.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
python3-neurodsp.noarch: W: summary-ended-with-dot C A tool for digital signal processing for neural time series.
python3-neurodsp.noarch: W: spelling-error %description -l en_US bandpass -> band pass, band-pass, bandannas
python3-neurodsp.noarch: W: spelling-error %description -l en_US highpass -> high pass, high-pass, highness
python3-neurodsp.noarch: W: spelling-error %description -l en_US lowpass -> low pass, low-pass, lowness
python3-neurodsp.noarch: W: spelling-error %description -l en_US aperiodic -> periodic, a periodic, DiCaprio
python3-neurodsp.noarch: E: no-changelogname-tag
python3-neurodsp.noarch: W: invalid-url URL: https://neurodsp-tools.github.io/ <urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 1 errors, 6 warnings.



Source checksums
----------------
https://github.com/neurodsp-tools/neurodsp/archive/2.0.0/neurodsp-2.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 410edb9d8d5fbc069f822598b6304fc57eff7246264c135b505e86761f4e3a33
  CHECKSUM(SHA256) upstream package : 410edb9d8d5fbc069f822598b6304fc57eff7246264c135b505e86761f4e3a33


Requires
--------
python3-neurodsp (rpmlib, GLIBC filtered):
    python(abi)
    python3.8dist(matplotlib)
    python3.8dist(numpy)
    python3.8dist(scipy)



Provides
--------
python3-neurodsp:
    python-neurodsp
    python3-neurodsp
    python3.8dist(neurodsp)
    python3dist(neurodsp)



Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -b 1751846
Buildroot used: fedora-rawhide-{{ target_arch }}
Active plugins: Generic, Shell-api, Python
Disabled plugins: Java, SugarActivity, PHP, Ocaml, fonts, R, C/C++, Haskell, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Updated Spec URL: https://major.fedorapeople.org/python-neurodsp/python-neurodsp.spec
Updated SRPM URL: https://major.fedorapeople.org/python-neurodsp/python-neurodsp-2.0.0-1.fc30.src.rpm

It would not be possible to include examples/ or tutorials/ as they both are built using sphinx but, examples/ has plot_mne_example.py which depends on python-mne and requires an additional dataset.

The upstream also does not provide any signatures that can be used to verify the source.

EEk, I think you forgot to regenerate the SRPM after making changes to the spec. Please do that, otherwise fedora-review will use this old srpm and won't run tests etc when it does the build.

Ahh... I uploaded the previous SRPM... I generated that one on F30.. :P

Here is the updated SRPM: https://major.fedorapeople.org/python-neurodsp/python-neurodsp-2.0.0-1.fc31.src.rpm

Looks good now. XXX APPROVED XXXX

- Please remove the dot at the end of the summary before you import. RPMlint pointed this out:

python3-neurodsp.noarch: W: summary-ended-with-dot C A tool for digital signal processing for neural time series.


- You can now continue from Step 7 here:
https://fedoraproject.org/wiki/New_package_process_for_existing_contributors

- Please give neuro-sig commit access to the repo when it has been created.

Cheers!

Thanks a lot for the review, doc!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-neurodsp

FEDORA-2019-51a828b70a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-51a828b70a

FEDORA-2019-7cb3dd8702 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7cb3dd8702

python-neurodsp-2.0.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-51a828b70a

python-neurodsp-2.0.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7cb3dd8702

python-neurodsp-2.0.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

python-neurodsp-2.0.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.