Bug 1752568

Summary: [V2V][UI] Empty cluster from infrastructure map should return meaningful message
Product: Red Hat CloudForms Management Engine Reporter: Yadnyawalk Tale <ytale>
Component: V2VAssignee: Mike Turley <mturley>
Status: CLOSED CURRENTRELEASE QA Contact: Md Nadeem <mnadeem>
Severity: low Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: low    
Version: 5.11.0CC: akarol, bthurber, fdupont, mfeifer, mnadeem, pvauter, vconzola
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.12.0Flags: mfeifer: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1805906 (view as bug list) Environment:
Last Closed: 2020-10-26 16:13:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1805906    
Attachments:
Description Flags
issue.mp4 none

Description Yadnyawalk Tale 2019-09-16 16:24:01 UTC
Created attachment 1615564 [details]
issue.mp4

Description of problem:
If your cluster is empty then it should tell that 'No datastore is present' instead of it is giving 'All source datastores have been mapped'


Version-Release number of selected component (if applicable):
5.11.0.23


How reproducible:
100%


Steps to Reproduce:
1. Map EmptyCluster with OSP project
2. On 'Map Storage' tab of modal, you will find 'All source datastores have been mapped.' in source selection box.


Actual results:
Should not get that Note.


Expected results:
Should get note which says there is no datastore.


Additional info:
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1677677#c0.

Comment 6 vconzola 2019-09-24 18:55:10 UTC
Hey Brett - Looking at this BZ with Mike and we have a question. Can a cluster ever exist with no datastores? Right now, we block the user from continuing in the mapping wizard until at least one datastore from each source cluster is mapped. Trying to decide if this is a UI bug? Y-Tale ran across this in a test and we're not sure if it's a valid use case. Thanks.

Comment 7 Brett Thurber 2019-09-24 19:39:44 UTC
(In reply to vconzola from comment #6)
> Hey Brett - Looking at this BZ with Mike and we have a question. Can a
> cluster ever exist with no datastores? Right now, we block the user from
> continuing in the mapping wizard until at least one datastore from each
> source cluster is mapped. Trying to decide if this is a UI bug? Y-Tale ran
> across this in a test and we're not sure if it's a valid use case. Thanks.

Without datastores there are no VM's or VM templates.  Invalid use case IMO.

Comment 8 Mike Turley 2019-09-24 20:25:50 UTC
Is it technically possible to have a cluster without any VMs (and therefore without any datastores) though? If so, the error messaging should still be improved if a user tries to select an empty cluster like this.

Comment 9 Brett Thurber 2019-09-24 21:20:58 UTC
(In reply to Mike Turley from comment #8)
> Is it technically possible to have a cluster without any VMs (and therefore
> without any datastores) though? If so, the error messaging should still be
> improved if a user tries to select an empty cluster like this.

Being empty negates the whole reason to try and initiate a migration however.  

The other side of this is if there is something incorrect within CloudForms causing a populated/configured VMware env to not display any clusters or datastores.  That would be the only "valid" reason to display an error message.

Comment 10 Mike Turley 2020-01-14 22:18:08 UTC
PR: https://github.com/ManageIQ/manageiq-v2v/pull/1090