Bug 1752568 - [V2V][UI] Empty cluster from infrastructure map should return meaningful message
Summary: [V2V][UI] Empty cluster from infrastructure map should return meaningful message
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.11.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: GA
: 5.12.0
Assignee: Mike Turley
QA Contact: Md Nadeem
Red Hat CloudForms Documentation
URL:
Whiteboard: v2v
Depends On:
Blocks: 1805906
TreeView+ depends on / blocked
 
Reported: 2019-09-16 16:24 UTC by Yadnyawalk Tale
Modified: 2020-10-26 16:13 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1805906 (view as bug list)
Environment:
Last Closed: 2020-10-26 16:13:51 UTC
Category: Bug
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:
mfeifer: mirror+


Attachments (Terms of Use)
issue.mp4 (217.93 KB, video/mp4)
2019-09-16 16:24 UTC, Yadnyawalk Tale
no flags Details

Description Yadnyawalk Tale 2019-09-16 16:24:01 UTC
Created attachment 1615564 [details]
issue.mp4

Description of problem:
If your cluster is empty then it should tell that 'No datastore is present' instead of it is giving 'All source datastores have been mapped'


Version-Release number of selected component (if applicable):
5.11.0.23


How reproducible:
100%


Steps to Reproduce:
1. Map EmptyCluster with OSP project
2. On 'Map Storage' tab of modal, you will find 'All source datastores have been mapped.' in source selection box.


Actual results:
Should not get that Note.


Expected results:
Should get note which says there is no datastore.


Additional info:
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1677677#c0.

Comment 6 vconzola 2019-09-24 18:55:10 UTC
Hey Brett - Looking at this BZ with Mike and we have a question. Can a cluster ever exist with no datastores? Right now, we block the user from continuing in the mapping wizard until at least one datastore from each source cluster is mapped. Trying to decide if this is a UI bug? Y-Tale ran across this in a test and we're not sure if it's a valid use case. Thanks.

Comment 7 Brett Thurber 2019-09-24 19:39:44 UTC
(In reply to vconzola from comment #6)
> Hey Brett - Looking at this BZ with Mike and we have a question. Can a
> cluster ever exist with no datastores? Right now, we block the user from
> continuing in the mapping wizard until at least one datastore from each
> source cluster is mapped. Trying to decide if this is a UI bug? Y-Tale ran
> across this in a test and we're not sure if it's a valid use case. Thanks.

Without datastores there are no VM's or VM templates.  Invalid use case IMO.

Comment 8 Mike Turley 2019-09-24 20:25:50 UTC
Is it technically possible to have a cluster without any VMs (and therefore without any datastores) though? If so, the error messaging should still be improved if a user tries to select an empty cluster like this.

Comment 9 Brett Thurber 2019-09-24 21:20:58 UTC
(In reply to Mike Turley from comment #8)
> Is it technically possible to have a cluster without any VMs (and therefore
> without any datastores) though? If so, the error messaging should still be
> improved if a user tries to select an empty cluster like this.

Being empty negates the whole reason to try and initiate a migration however.  

The other side of this is if there is something incorrect within CloudForms causing a populated/configured VMware env to not display any clusters or datastores.  That would be the only "valid" reason to display an error message.

Comment 10 Mike Turley 2020-01-14 22:18:08 UTC
PR: https://github.com/ManageIQ/manageiq-v2v/pull/1090


Note You need to log in before you can comment on or make changes to this bug.