Bug 175281
Summary: | Review Request: perl-Tie-EncryptedHash | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Tie-EncryptedHash/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-02-08 07:55:54 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 168580 | ||
Bug Blocks: | 163779 |
Description
Paul Howarth
2005-12-08 15:01:13 UTC
perl-Crypt-DES isn't built on the FC-4 branch yet so I build it from CVS. There's not really much to this package. The shebang line at the top of the module is odd; thanks for removing it. Good stuff: pmlint is completely silent. Package meets naming and packaging guidelines. Specfile is properly named, legible, and uses macros consistently. BuildRequires: is proper. License is acceptable and matches License: tag. Source file md5sum matches upstream. Package builds and installs on FC4 x86 and FC3 x86_64. Odd stuff: The tests spew a few (nine) warnings. They don't seem to affect the outcome. t/operations test takes fifteen seconds on FC3 x86_64 but seems to be instantaneous on i386. Everything does build and pass on x86_64 so I'm not sure what the issue is. I see no reason why either of these should be blockers. Approved. Thanks for the review. Build on target fedora-development-extras succeeded. I'm not sure about the test issues either, but there don't seems to be any bugs on rt.cpan.org and this module release is getting on for 4 years old now, so I reckon it's OK. Package Change Request ====================== Package Name: perl-Tie-EncryptedHash New Branches: EL-4 EL-5 Owners: pghmcfc InitialCC: perl-sig cvs done. |