Red Hat Bugzilla – Bug 175281
Review Request: perl-Tie-EncryptedHash
Last modified: 2009-03-12 23:06:48 EDT
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Tie-EncryptedHash/perl-Tie-EncryptedHash.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Tie-EncryptedHash/perl-Tie-EncryptedHash-1.21-1.src.rpm
Tie::EncryptedHash augments Perl hash semantics to build secure, encrypting
containers of data. Tie::EncryptedHash introduces special hash fields that are
coupled with encrypt/decrypt routines to encrypt assignments at STORE() and
decrypt retrievals at FETCH(). By design, encrypting fields are associated with
keys that begin in single underscore. The remaining keyspace is used for
accessing normal hash fields, which are retained without modification.
While the password is set, a Tie::EncryptedHash behaves exactly like a standard
Perl hash. This is its transparent mode of access. Encrypting and normal fields
are identical in this mode. When password is deleted, encrypting fields are
accessible only as ciphertext. This is Tie::EncryptedHash's opaque mode of
access, optimized for serialization.
Encryption is done with Crypt::CBC(3), which encrypts in the cipher block
chaining mode with Blowfish, DES or IDEA. Tie::EncryptedHash uses Blowfish by
default, but can be instructed to employ any cipher supported by Crypt::CBC(3).
perl-Crypt-DES isn't built on the FC-4 branch yet so I build it from CVS.
There's not really much to this package. The shebang line at the top of the
module is odd; thanks for removing it.
pmlint is completely silent.
Package meets naming and packaging guidelines.
Specfile is properly named, legible, and uses macros consistently.
BuildRequires: is proper.
License is acceptable and matches License: tag.
Source file md5sum matches upstream.
Package builds and installs on FC4 x86 and FC3 x86_64.
The tests spew a few (nine) warnings. They don't seem to affect the outcome.
t/operations test takes fifteen seconds on FC3 x86_64 but seems to be
instantaneous on i386. Everything does build and pass on x86_64 so I'm not sure
what the issue is.
I see no reason why either of these should be blockers.
Thanks for the review.
Build on target fedora-development-extras succeeded.
I'm not sure about the test issues either, but there don't seems to be any bugs
on rt.cpan.org and this module release is getting on for 4 years old now, so I
reckon it's OK.
Package Change Request
Package Name: perl-Tie-EncryptedHash
New Branches: EL-4 EL-5