Bug 175463

Summary:	Review Request: tclsoap - SOAP support for Tcl
Product:	[Fedora] Fedora	Reporter:	Wart <wart>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-01-29 16:21:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	174278
Bug Blocks:	163779

Description Wart 2005-12-11 05:07:10 UTC

Spec Name or Url: http://www.kobold.org/~wart/fedora/tclsoap.spec
SRPM Name or Url: http://www.kobold.org/~wart/fedora/tclsoap-1.6.7-1.src.rpm
MD5SUMs: http://www.kobold.org/~wart/fedora/MD5SUM.asc
Description:
Provides support for building clients and servers for the
SOAP remote procedure call protocol from Tcl.  When combined with tclhttpd (already in FE) this provides a nice SOAP server platform for Tcl.

Comment 1 John Mahowald 2006-01-29 03:11:14 UTC

Good:

- rpmlint clean
- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

Comment 2 Wart 2006-01-29 16:21:24 UTC

Package imported and built without problems on devel.

Thanks for the review!