Spec Name or Url: http://www.kobold.org/~wart/fedora/tcldom.spec SRPM Name or Url: http://www.kobold.org/~wart/fedora/tcldom-3.0-2.src.rpm Description: tcldom provides DOM bindings for the Tcl scripting language. It provides DOM processing based on either a pure-tcl implemention or using the gnome libxml2 library.
Updated to new upstream sources: http://www.kobold.org/~wart/fedora/tcldom.spec http://www.kobold.org/~wart/fedora/tcldom-3.1-1.src.rpm http://www.kobold.org/~wart/fedora/MD5SUM.asc
- package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC4 i386 - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - devel requires base package n-v-r However, - Have you tested this on 64 bit? %{_libdir} may prove problematic - BuildRoot should be cleaned at the beginning of %install. - A bunch of compiler warnings, particularly in tcldomlibxml2.c. Be sure to tell upstream about this, and show them your patch.
My primary development machine is dual x86_64, and I haven't noticed any build or runtime problems with %{_libdir}. But I did notice a minor problem loading the pure-tcl dom library that has been fixed in an updated patch in this next package. BuildRoot is now cleaned at the beginning of %install All patches have been sent upstream, and I've notified the upstream developers about the compiler warnings. Upstream doesn't release new packages very often, so I don't expect to see them adopt the patches anytime soon. New spec file and src rpm: http://www.kobold.org/~wart/fedora/tcldom.spec http://www.kobold.org/~wart/fedora/tcldom-3.1-2.src.rpm
Looks good. APPROVED
Many thanks for the review!
Package Change Request ====================== Package Name: tcldom New Branches: EL-4 EL-5
cvs done.