Bug 1756991

Summary:	2 inputs with same name -> uninitialized constant #<Class:0x000000000b894c38>::NonUniqueInputsError
Product:	Red Hat Satellite	Reporter:	Lukáš Hellebrandt <lhellebr>
Component:	Reporting	Assignee:	Shira Maximov <mshira>
Status:	CLOSED ERRATA	QA Contact:	Lukáš Hellebrandt <lhellebr>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.6.0	CC:	egolov, inecas, mhulan, mshira, oprazak, wpinheir
Target Milestone:	6.8.0	Keywords:	Triaged, UserExperience
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-2.1.0-0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 12:59:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lukáš Hellebrandt 2019-09-30 11:36:30 UTC

Description of problem:
When creating a template with 2 inputs with the same name, the error "uninitialized constant #<Class:0x000000000b894c38>::NonUniqueInputsError" appears and the operation fails. No traceback in production.log. Failure is expected but it should be handled better: the message should be more user friendly and preferably, the check should be handled before submitting the form.

Version-Release number of selected component (if applicable):
Reproduced on Sat 6.6 snap 22.

How reproducible:
Deterministic

Steps to Reproduce:
1. Monitor -> Report Templates -> Create
2. Set name
3. Go to Inputs tab
4. Add input, name it "abc"
5. Add another input, name it "abc"
6. Submit

Actual results:
Error, operation failed

Expected results:
(Form not submittable because this is checked by Javascript before submission). Better error message.

Comment 3 Shira Maximov 2020-02-12 08:15:47 UTC

Created redmine issue https://projects.theforeman.org/issues/28995 from this bug

Comment 4 Bryan Kearney 2020-02-26 17:05:11 UTC

Upstream bug assigned to mshira

Comment 5 Bryan Kearney 2020-02-26 17:05:13 UTC

Upstream bug assigned to mshira

Comment 6 Bryan Kearney 2020-02-27 09:05:19 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/28995 has been resolved.

Comment 7 Lukáš Hellebrandt 2020-06-10 12:17:15 UTC

Verified with Sat 6.8 snap 3.0.

Using reproducer from OP, after submitting, I get:
```
Unable to save
ERF42-3514 [Foreman::Exception]: Duplicated inputs detected: ["abc"]
```

Using Hammer, I get (no change here):
```
Could not create the template input:
  Name has already been taken
```

Adding different-named inputs works.

Comment 10 errata-xmlrpc 2020-10-27 12:59:02 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.8 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4366