Description of problem: When creating a template with 2 inputs with the same name, the error "uninitialized constant #<Class:0x000000000b894c38>::NonUniqueInputsError" appears and the operation fails. No traceback in production.log. Failure is expected but it should be handled better: the message should be more user friendly and preferably, the check should be handled before submitting the form. Version-Release number of selected component (if applicable): Reproduced on Sat 6.6 snap 22. How reproducible: Deterministic Steps to Reproduce: 1. Monitor -> Report Templates -> Create 2. Set name 3. Go to Inputs tab 4. Add input, name it "abc" 5. Add another input, name it "abc" 6. Submit Actual results: Error, operation failed Expected results: (Form not submittable because this is checked by Javascript before submission). Better error message.
Created redmine issue https://projects.theforeman.org/issues/28995 from this bug
Upstream bug assigned to mshira
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/28995 has been resolved.
Verified with Sat 6.8 snap 3.0. Using reproducer from OP, after submitting, I get: ``` Unable to save ERF42-3514 [Foreman::Exception]: Duplicated inputs detected: ["abc"] ``` Using Hammer, I get (no change here): ``` Could not create the template input: Name has already been taken ``` Adding different-named inputs works.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Satellite 6.8 release), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:4366