Bug 1758005
| Summary: | build xlockmore for epel8 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Derek Schrock <dereks> | ||||
| Component: | xlockmore | Assignee: | Adrian Reber <adrian> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | epel8 | CC: | adrian, mcermak | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | Bug | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Derek Schrock
2019-10-02 23:26:59 UTC
I am open to have xlockmore use any other icon. No problem. Can you provide a patch? Or do you want to maintain the epel8 branch. If you set me as the co-maintainer, I can try to build it. No promises though. Created attachment 1625720 [details]
Use adwaita-icon-theme's system-lock-screen icon
Using rpms/xlockmore master branch to build xlockmore for EL8 update Requires from gnome-icon-theme/gnome-icon-theme-legacy to adwaita-icon-theme system-lock-screen.
So it turns out the el7 package is semi-broken since gnome-icon-theme (xlockmore's require) doesn't provide a icon gnome-lockscreen. It's from gnome-icon-theme-legacy. However, it appears the same icon is provided by adwaita-icon-theme's system-lock-screen. Using the attached patch I removed the if-rhel and only using adwaita-icon-theme system-lock-screen. Built xlockmore for EL8 via mock and installed without issue. adwaita-icon-theme is in RHEL 7/8 and Fedora 29+ The icon appears as expected in gnome when using the .desktop item searching for xlock. (In reply to Martin Cermak from comment #2) > If you set me as the co-maintainer, I can try to build it. No promises > though. You are already listed as xlockmore member. I think you be able to commit to xlockmore. Do you need any more permissions? Any update on this? Any reason the attached patch can't be used to create the epel8 branch? Following up to see if this package will be co-maintained? If needed I can maintain the epel8 branch. (In reply to Derek Schrock from comment #7) > Following up to see if this package will be co-maintained? If needed I can > maintain the epel8 branch. Let me know your FAS name I can add you to the package and you can request the EPEL 8 branch and maintain it. (In reply to Adrian Reber from comment #8) > (In reply to Derek Schrock from comment #7) > Let me know your FAS name I can add you to the package and you can request > the EPEL 8 branch and maintain it. derekschrock I cannot add derekschrok to xlockmore because that user does not seem to be in the packager group. Should I request sponsorship or should you request a co-maintainer at https://pagure.io/packager-sponsors? I have little Fedora exp. outside of submitted bug reports for RHEL/centos/epel: https://bugzilla.redhat.com/buglist.cgi?cmdtype=runnamed&list_id=10763890&namedcmd=My%20Bugs%20%28Closed%29 Majority of the current work is to get fvwm (1756673), distcc (1783740), and ccache (1784484) in EL8. When I get some free time this month I plan to package for pulseaudio-module-xrdp (1757616). If it has any bearing I actively maintain multiple packages for the FreeBSD ports tree: https://www.freshports.org/search.php?stype=maintainer&method=exact&query=dereks@lifeofadishwasher.com and https://bugs.freebsd.org/bugzilla/buglist.cgi?cmdtype=runnamed&list_id=332759&namedcmd=All%20My%20Bugs |