Bug 1758005 - build xlockmore for epel8
Summary: build xlockmore for epel8
Keywords:
Status: NEW
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: xlockmore
Version: epel8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-02 23:26 UTC by Derek Schrock
Modified: 2020-01-12 20:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)
Use adwaita-icon-theme's system-lock-screen icon (1.03 KB, patch)
2019-10-14 23:21 UTC, Derek Schrock
no flags Details | Diff

Description Derek Schrock 2019-10-02 23:26:59 UTC
To support fvwm for epel8, Bug 1756673, we need xlockmore for fvwm built in menus.

However, it appears xlockmore depends on gnome-icon-theme, this was removed in RHEL8 and doesn't have a direct replacement.

This dependency is just the icon file for the .desktop file?   Can xlockmore be built to use a supported package's icon file or maybe something that's part of the xlockmore distribution?

Comment 1 Adrian Reber 2019-10-14 11:55:05 UTC
I am open to have xlockmore use any other icon. No problem. Can you provide a patch? Or do you want to maintain the epel8 branch.

Comment 2 Martin Cermak 2019-10-14 13:22:08 UTC
If you set me as the co-maintainer, I can try to build it.  No promises though.

Comment 3 Derek Schrock 2019-10-14 23:21:06 UTC
Created attachment 1625720 [details]
Use adwaita-icon-theme's system-lock-screen icon

Using rpms/xlockmore master branch to build xlockmore for EL8 update Requires from gnome-icon-theme/gnome-icon-theme-legacy to adwaita-icon-theme system-lock-screen.

Comment 4 Derek Schrock 2019-10-14 23:30:07 UTC
So it turns out the el7 package is semi-broken since gnome-icon-theme (xlockmore's require) doesn't provide a icon gnome-lockscreen.  It's from gnome-icon-theme-legacy.

However, it appears the same icon is provided by adwaita-icon-theme's system-lock-screen.   Using the attached patch I removed the if-rhel and only using adwaita-icon-theme system-lock-screen.  Built xlockmore for EL8 via mock and installed without issue.  adwaita-icon-theme is in RHEL 7/8 and Fedora 29+

The icon appears as expected in gnome when using the .desktop item searching for xlock.

Comment 5 Adrian Reber 2019-10-15 13:10:33 UTC
(In reply to Martin Cermak from comment #2)
> If you set me as the co-maintainer, I can try to build it.  No promises
> though.

You are already listed as xlockmore member. I think you be able to commit to xlockmore. Do you need any more permissions?

Comment 6 Derek Schrock 2019-11-15 02:14:30 UTC
Any update on this?  Any reason the attached patch can't be used to create the epel8 branch?

Comment 7 Derek Schrock 2020-01-09 22:53:42 UTC
Following up to see if this package will be co-maintained?  If needed I can maintain the epel8 branch.

Comment 8 Adrian Reber 2020-01-10 08:08:32 UTC
(In reply to Derek Schrock from comment #7)
> Following up to see if this package will be co-maintained?  If needed I can
> maintain the epel8 branch.

Let me know your FAS name I can add you to the package and you can request the EPEL 8 branch and maintain it.

Comment 9 Derek Schrock 2020-01-10 22:49:53 UTC
(In reply to Adrian Reber from comment #8)
> (In reply to Derek Schrock from comment #7)
> Let me know your FAS name I can add you to the package and you can request
> the EPEL 8 branch and maintain it.

derekschrock

Comment 10 Adrian Reber 2020-01-12 13:00:46 UTC
I cannot add derekschrok to xlockmore because that user does not seem to be in the packager group.

Comment 11 Derek Schrock 2020-01-12 20:16:21 UTC
Should I request sponsorship or should you request a co-maintainer at https://pagure.io/packager-sponsors?

I have little Fedora exp. outside of submitted bug reports for RHEL/centos/epel: https://bugzilla.redhat.com/buglist.cgi?cmdtype=runnamed&list_id=10763890&namedcmd=My%20Bugs%20%28Closed%29

Majority of the current work is to get fvwm (1756673), distcc (1783740), and ccache (1784484) in EL8.  When I get some free time this month I plan to package for pulseaudio-module-xrdp (1757616).

If it has any bearing I actively maintain multiple packages for the FreeBSD ports tree: https://www.freshports.org/search.php?stype=maintainer&method=exact&query=dereks@lifeofadishwasher.com  and   https://bugs.freebsd.org/bugzilla/buglist.cgi?cmdtype=runnamed&list_id=332759&namedcmd=All%20My%20Bugs


Note You need to log in before you can comment on or make changes to this bug.