Bug 175895

Summary:	Review Request: perl-DBD-XBase - Perl module for reading and writing the dbf files
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Ralf Corsepius <rc040203>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list, tcallawa
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-12-17 01:09:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 175896

Description Jose Pedro Oliveira 2005-12-16 00:13:39 UTC

Spec Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-DBD-XBase.spec

SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-DBD-XBase-0.241-1.src.rpm

Description:
This module can read and write XBase database files, known as dbf in
dBase and FoxPro world. It also transparently reads memo fields from
the dbt, fpt and smt files and works with index files (ndx, ntx, mdx, idx,
cdx and SDBM). This module XBase.pm provides simple native interface
to XBase files. For DBI compliant database access, see DBD::XBase and
DBI modules and their man pages.

Note: This is a perl-SQL-Statement BR

Comment 1 Ralf Corsepius 2005-12-16 04:05:20 UTC

Basically the package seems OK to me, but I am seeing 2 minor issues with it:

1. The package contains /usr/bin/indexdump.
This name ("indexdump") seems too general/generic to me for this specialized
tools to have it in /usr/bin. May-be one should consider to split the
applications out of the perl-module package into a separate application package.
I am not sure.

2. Something it broken with the Makefile.
The ./bin/indexdump being generated inside when running "make" contains 
two "#!/usr/bin/perl -w" shebangs instead of one.

Anyway, APPROVED

Comment 2 Jose Pedro Oliveira 2005-12-16 19:45:17 UTC

(In reply to comment #1)
> Basically the package seems OK to me, but I am seeing 2 minor issues with it:
> 
> 1. The package contains /usr/bin/indexdump.
> This name ("indexdump") seems too general/generic to me for this specialized
> tools to have it in /usr/bin. May-be one should consider to split the
> applications out of the perl-module package into a separate application package.
> I am not sure.

Maybe renaming it to dbfindexdump in case of conflict?  The patch would have
to modified the Makefile.PL, some parts of the documentation, and at least a
test file.
 
> 2. Something it broken with the Makefile.
> The ./bin/indexdump being generated inside when running "make" contains 
> two "#!/usr/bin/perl -w" shebangs instead of one.

Corrected. Patched added to CVS (devel branch - tagged and built as release 2).

> Anyway, APPROVED

Thanks. 

PS - Still waiting for the FC-4 CVS branch creation.

Comment 3 Jose Pedro Oliveira 2005-12-17 01:09:16 UTC

FC-4 build completed.

Comment 4 Paul Howarth 2006-01-09 15:13:34 UTC

*** Bug 177272 has been marked as a duplicate of this bug. ***