Bug 1760191
| Summary: | Review Request: golang-github-sqshq-sampler - Tool for shell commands execution, visualization and alerting | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Artem <ego.cordatus> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-10-26 17:25:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1761357 | ||
| Bug Blocks: | |||
|
Description
Artem
2019-10-10 06:04:38 UTC
Don't include the binary: # Generated by go2rpm 1 %bcond_without check # https://github.com/gizak/termui %global goipath github.com/gizak/termui Version: 3.1.0 %gometa %global common_description %{expand: Golang terminal dashboard.} %global golicenses LICENSE %global godocs _examples CHANGELOG.md README.md Name: %{goname} Release: 1%{?dist} Summary: Golang terminal dashboard License: MIT URL: %{gourl} Source0: %{gosource} BuildRequires: golang(github.com/mattn/go-runewidth) BuildRequires: golang(github.com/mitchellh/go-wordwrap) BuildRequires: golang(github.com/nsf/termbox-go) %description %{common_description} %gopkg %prep %goprep %install %gopkginstall %if %{with check} %check %gocheck %endif %gopkgfiles %changelog - Remove
metadata/license_test.go\\\
metadata/license.go
from both license field
Build error:
# pkg-config --cflags -- alsa
Package alsa was not found in the pkg-config search path.
Perhaps you should add the directory containing `alsa.pc'
to the PKG_CONFIG_PATH environment variable
Package 'alsa', required by 'virtual:world', not found
pkg-config: exit status 1
Add
BuildRequires: pkgconfig(alsa)
Also add a Requires for the devel package:
%global godevelheader %{expand:
Requires: pkgconfig(alsa)}
%global common_description %{expand:
@eclipseo, thx a lot. It compiles and works. https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01056774-golang-github-sqshq-sampler/golang-github-sqshq-sampler.spec https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01056774-golang-github-sqshq-sampler/golang-github-sqshq-sampler-1.0.3-2.fc32.src.rpm --- I suggest put with repo few .yml configs as examples. What do you think? If yes, in %doc or in /etc/xdg/sampler for example and then they can work out of box (probably, need to test). If you wish, add them in %doc imho. Package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-sqshq-sampler FEDORA-2019-28e1174269 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-28e1174269 golang-github-sqshq-sampler-1.0.3-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |