Bug 1760191 - Review Request: golang-github-sqshq-sampler - Tool for shell commands execution, visualization and alerting
Summary: Review Request: golang-github-sqshq-sampler - Tool for shell commands executi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1761357
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-10 06:04 UTC by Artem
Modified: 2019-10-26 17:25 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-10-26 17:25:57 UTC
Type: Bug
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Artem 2019-10-10 06:04:38 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01046220-golang-github-sqshq-sampler/golang-github-sqshq-sampler.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01046220-golang-github-sqshq-sampler/golang-github-sqshq-sampler-1.0.3-1.fc32.src.rpm

Description:
Tool for shell commands execution, visualization and alerting.

---

Packaged all necessary dependencies for this app except one:
golang-github-gizak-termui

I am just starting with Go packages so can't fix 'golang-github-gizak-termui' right now. Would be great if someone help with this package and then we can push this Sampler app.

Here is build log of 'golang-github-gizak-termui':

https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01052004-golang-github-gizak-termui/builder-live.log.gz

Comment 1 Robert-André Mauchin 🐧 2019-10-12 15:26:35 UTC
Don't include the binary:

# Generated by go2rpm 1
%bcond_without check

# https://github.com/gizak/termui
%global goipath         github.com/gizak/termui
Version:                3.1.0

%gometa

%global common_description %{expand:
Golang terminal dashboard.}

%global golicenses      LICENSE
%global godocs          _examples CHANGELOG.md README.md

Name:           %{goname}
Release:        1%{?dist}
Summary:        Golang terminal dashboard

License:        MIT
URL:            %{gourl}
Source0:        %{gosource}

BuildRequires:  golang(github.com/mattn/go-runewidth)
BuildRequires:  golang(github.com/mitchellh/go-wordwrap)
BuildRequires:  golang(github.com/nsf/termbox-go)

%description
%{common_description}

%gopkg

%prep
%goprep

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog

Comment 2 Robert-André Mauchin 🐧 2019-10-12 18:19:23 UTC
 - Remove 

metadata/license_test.go\\\
                        metadata/license.go

  from both license field

 Build error:

# pkg-config --cflags  -- alsa
Package alsa was not found in the pkg-config search path.
Perhaps you should add the directory containing `alsa.pc'
to the PKG_CONFIG_PATH environment variable
Package 'alsa', required by 'virtual:world', not found
pkg-config: exit status 1

Add 

BuildRequires:  pkgconfig(alsa)

Comment 3 Robert-André Mauchin 🐧 2019-10-13 16:06:21 UTC
Also add a Requires for the devel package:

%global godevelheader %{expand:
Requires:       pkgconfig(alsa)}

%global common_description %{expand:

Comment 4 Artem 2019-10-14 12:01:29 UTC
@eclipseo, thx a lot. It compiles and works.

https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01056774-golang-github-sqshq-sampler/golang-github-sqshq-sampler.spec

https://copr-be.cloud.fedoraproject.org/results/atim/sampler/fedora-rawhide-x86_64/01056774-golang-github-sqshq-sampler/golang-github-sqshq-sampler-1.0.3-2.fc32.src.rpm

---

I suggest put with repo few .yml configs as examples. What do you think? If yes, in %doc or in /etc/xdg/sampler for example and then they can work out of box (probably, need to test).

Comment 5 Robert-André Mauchin 🐧 2019-10-14 14:11:48 UTC
If you wish, add them in %doc imho.

Package approved.

Comment 6 Gwyn Ciesla 2019-10-14 20:21:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-sqshq-sampler

Comment 7 Fedora Update System 2019-10-15 00:03:10 UTC
FEDORA-2019-28e1174269 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-28e1174269

Comment 8 Fedora Update System 2019-10-26 17:25:57 UTC
golang-github-sqshq-sampler-1.0.3-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.