Bug 1760197

Summary:	[UPI] GCP backend for api server has incorrect ranges allowed for heath checks
Product:	OpenShift Container Platform	Reporter:	Johnny Liu <jialiu>
Component:	Installer	Assignee:	Patrick Dillon <padillon>
Installer sub component:	openshift-installer	QA Contact:	liujia <jiajliu>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	adahiya, bleanhar, jialiu, padillon, vlaad, wsun, xtian
Version:	4.2.0
Target Milestone:	---
Target Release:	4.2.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1759966
Clones:	1760425 (view as bug list)		Environment:
Last Closed:	2019-10-30 04:44:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1760425
Bug Blocks:

Description Johnny Liu 2019-10-10 06:25:46 UTC

The same change is also need synced to UPI template.
https://github.com/openshift/installer/blob/master/upi/gcp/03_security.py#L40

+++ This bug was initially created as a clone of Bug #1759966 +++

+++ This bug was initially created as a clone of Bug #1759965 +++

Description of problem:

Based on https://cloud.google.com/load-balancing/docs/health-checks#fw-rule the ranges that should be allowed are `"35.191.0.0/16", "209.85.152.0/22", "209.85.204.0/22"`

But gcp firewall rule only allows `"35.191.0.0/16", "130.211.0.0/22"`

This causes health checks to api server fail when the source IPs is from `"209.85.152.0/22" or "209.85.204.0/22"``


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create cluster on GCP
2. Look at the firewall rule for the health checks


Actual results:
Health checks fail due to firewall rules.

Expected results:
Correct ranges are allowed

Additional info:

--- Additional comment from Scott Dodson on 2019-10-09 14:35:12 UTC ---

Without this the load balancer will be denied access to the apiservers and will incorrectly remove members. We don't have a good method to measure how often we've been seeing this in CI, we may have just been getting lucky and only ending up with NLBs in the 1 of 3 ranges that are currently included which were correct.

--- Additional comment from Johnny Liu on 2019-10-10 06:24:10 UTC ---

4.2 PR:
https://github.com/openshift/installer/commit/f0e25273cf9512b4aa99c26acdd153007d046e2d


Verified this bug with 4.2.0-0.nightly-2019-10-09-203306, and PASS.

Installation is completed successfully.

Check source IP range in jialiu-w65g6-master-in-from-health-checks:

Source filters
IP ranges
209.85.204.0/22
209.85.152.0/22
35.191.0.0/16

Comment 3 Brenton Leanhardt 2019-10-10 13:34:17 UTC

https://github.com/openshift/openshift-docs/pull/17043 is the docs PR.  Update incoming.

Comment 4 Johnny Liu 2019-10-11 01:33:27 UTC

Not only document, https://github.com/openshift/installer/blob/release-4.2/upi/gcp/03_security.py#L47 also should be fixed, right?

Comment 5 Brenton Leanhardt 2019-10-11 12:25:38 UTC

Correct, an installer PR is in flight too: https://github.com/openshift/installer/pull/2488/files.  The docs are the most critical aspect for 4.2 GA though.  The installer PR might have to merge in the first errata.

Comment 8 liujia 2019-10-23 08:43:16 UTC

Version:4.2.0-0.nightly-2019-10-23-011659

Installation succeed.

Checked jliu-b-8cbcl-health-checks's IP ranges
35.191.0.0/16
209.85.152.0/22
209.85.204.0/22

comply with https://github.com/openshift/installer/pull/2488/commits/0d47fdba63d79b65de34fee6d6c1af218ee3b641

Comment 10 errata-xmlrpc 2019-10-30 04:44:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3151