Bug 1765186

Summary:	Problematic coding practices at logger
Product:	[Community] GlusterFS	Reporter:	Barak Sason Rofman <bsasonro>
Component:	logging	Assignee:	Barak Sason Rofman <bsasonro>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-20 12:31:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Barak Sason Rofman 2019-10-24 13:24:53 UTC

Description of problem:
There are currently several problematic coding practices regarding the logger:
1 - Code duplication of "log_levels" array
2 - static methods are not declared at the begging of the .c file
3 - Unused structs are defined in the .c file

This issues should be addressed in order to improve readability and maintainability.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-10-24 13:32:06 UTC

REVIEW: https://review.gluster.org/23611 (libglusterfs/logger - code cleaning) posted (#1) for review on master by Barak Sason Rofman

Comment 2 Worker Ant 2019-12-20 12:31:41 UTC

REVIEW: https://review.gluster.org/23611 (libglusterfs/logger - code cleaning) merged (#8) on master by Amar Tumballi