Bug 1765186 - Problematic coding practices at logger
Summary: Problematic coding practices at logger
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: logging
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Barak Sason Rofman
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-24 13:24 UTC by Barak Sason Rofman
Modified: 2019-12-20 12:31 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-20 12:31:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 23611 0 None Merged libglusterfs/logger - code cleaning 2019-12-20 12:31:40 UTC

Description Barak Sason Rofman 2019-10-24 13:24:53 UTC 
Description of problem:
There are currently several problematic coding practices regarding the logger:
1 - Code duplication of "log_levels" array
2 - static methods are not declared at the begging of the .c file
3 - Unused structs are defined in the .c file

This issues should be addressed in order to improve readability and maintainability.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2019-10-24 13:32:06 UTC 
REVIEW: https://review.gluster.org/23611 (libglusterfs/logger - code cleaning) posted (#1) for review on master by Barak Sason Rofman
Comment 2 Worker Ant 2019-12-20 12:31:41 UTC 
REVIEW: https://review.gluster.org/23611 (libglusterfs/logger - code cleaning) merged (#8) on master by Amar Tumballi
Note You need to log in before you can comment on or make changes to this bug.