Bug 1765727

Summary: Review Request: gap-pkg-circle - Adjoint groups of finite rings
Product: [Fedora] Fedora Reporter: Jerry James <loganjerry>
Component: Package ReviewAssignee: Gerald Cox <gbcox>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: gbcox, package-review
Target Milestone: ---Flags: gbcox: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-15 03:01:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jerry James 2019-10-25 20:03:58 UTC 
Spec URL: https://jjames.fedorapeople.org/gap-pkg-circle/gap-pkg-circle.spec
SRPM URL: https://jjames.fedorapeople.org/gap-pkg-circle/gap-pkg-circle-1.6.1-1.fc32.src.rpm
RPMLINTRC URL: https://jjames.fedorapeople.org/gap-pkg-circle/gap-pkg-circle.rpmlintrc
Fedora Account System Username: jjames
Description: Let R be an associative ring, not necessarily with a unit element.  The set of all elements of R forms a monoid with the neutral element 0 from R under the operation r*s = r + s + rs defined for all r,s from R.  This operation is called 'circle multiplication'; it is also known as 'star multiplication'.  The monoid of elements of R under circle multiplication is called the adjoint semigroup of R.  The group of all invertible elements of this monoid is called the adjoint group of R.

These notions naturally lead to a number of questions about the connection between a ring and its adjoint group, for example, how the ring properties will determine properties of the adjoint group; which groups can appear as adjoint groups of rings; which rings can have adjoint groups with prescribed properties, etc.

The main objective of the GAP package 'Circle' is to extend GAP functionality for computations in adjoint groups of associative rings to make it possible to use the GAP system for the investigation of such questions.

Circle provides functionality to construct circle objects that will respect circle multiplication r*s = r + s + rs, create multiplicative groups, generated by these objects, and compute groups of elements, invertible with respect to this operation, for finite radical algebras and finite associative rings without one.
Comment 1 Gerald Cox 2019-10-31 19:47:03 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package does not own files or directories owned by other packages.
  Could the using the %dir directive resolve this?
  See:  https://stackoverflow.com/questions/30067649/rpmbuild-common-ownership-of-directories

Non-blocking Issues:

- https://gap-packages.github.io/circle/ <urlopen error [Errno -2] Name or service not known>
  I manually checked and it works fine, so not sure why rpmlint was throwing a warning.

- incorrect-fsf-address /usr/share/licenses/gap-pkg-circle/COPYING
  In all cases, upstream SHOULD be informed about this. 
  This is the only requirement with respect to this error.

- only-non-binary-in-usr-lib - invalid warning
  See:  https://bugzilla.redhat.com/show_bug.cgi?id=436500

=== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib/gap/pkg/circle-1.6.1(set, C, locale,, Failed, to,
     defaulting), /usr/lib/gap/pkg/circle-1.6.1/lib(set, C, locale,,
     Failed, to, defaulting), /usr/lib/gap/pkg/circle-1.6.1/tst(set, C,
     locale,, Failed, to, defaulting), /usr/share/doc/gap-pkg-circle(set,
     C, locale,, Failed, to, defaulting), /usr/share/licenses/gap-pkg-
     circle(set, C, locale,, Failed, to, defaulting),
     /usr/lib/gap/pkg/circle-1.6.1/doc(set, C, locale,, Failed, to,
     defaulting)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gap-pkg-circle-1.6.1-1.fc32.noarch.rpm
          gap-pkg-circle-doc-1.6.1-1.fc32.noarch.rpm
          gap-pkg-circle-1.6.1-1.fc32.src.rpm
gap-pkg-circle.noarch: W: spelling-error Summary(en_US) Adjoint -> Adjoin, Adjoins, Ad joint
gap-pkg-circle.noarch: W: spelling-error %description -l en_US monoid -> mono id, mono-id, monoxide
gap-pkg-circle.noarch: W: spelling-error %description -l en_US adjoint -> adjoin, adjoins, ad joint
gap-pkg-circle.noarch: W: spelling-error %description -l en_US semigroup -> semi group, semi-group, semipro
gap-pkg-circle.noarch: W: spelling-error %description -l en_US invertible -> convertible, revertible
gap-pkg-circle.noarch: W: only-non-binary-in-usr-lib
gap-pkg-circle.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-circle/COPYING
gap-pkg-circle-doc.noarch: W: only-non-binary-in-usr-lib
gap-pkg-circle-doc.noarch: W: no-documentation
gap-pkg-circle.src: W: spelling-error Summary(en_US) Adjoint -> Adjoin, Adjoins, Ad joint
gap-pkg-circle.src: W: spelling-error %description -l en_US monoid -> mono id, mono-id, monoxide
gap-pkg-circle.src: W: spelling-error %description -l en_US adjoint -> adjoin, adjoins, ad joint
gap-pkg-circle.src: W: spelling-error %description -l en_US semigroup -> semi group, semi-group, semipro
gap-pkg-circle.src: W: spelling-error %description -l en_US invertible -> convertible, revertible
3 packages and 0 specfiles checked; 1 errors, 13 warnings.




Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
gap-pkg-circle-doc.noarch: W: invalid-url URL: https://gap-packages.github.io/circle/ <urlopen error [Errno -2] Name or service not known>
gap-pkg-circle-doc.noarch: W: only-non-binary-in-usr-lib
gap-pkg-circle-doc.noarch: W: no-documentation
gap-pkg-circle.noarch: W: spelling-error Summary(en_US) Adjoint -> Adjoin, Adjoins, Ad joint
gap-pkg-circle.noarch: W: spelling-error %description -l en_US monoid -> mono id, mono-id, monoxide
gap-pkg-circle.noarch: W: spelling-error %description -l en_US adjoint -> adjoin, adjoins, ad joint
gap-pkg-circle.noarch: W: spelling-error %description -l en_US semigroup -> semi group, semi-group, semipro
gap-pkg-circle.noarch: W: spelling-error %description -l en_US invertible -> convertible, revertible
gap-pkg-circle.noarch: W: invalid-url URL: https://gap-packages.github.io/circle/ <urlopen error [Errno -2] Name or service not known>
gap-pkg-circle.noarch: W: only-non-binary-in-usr-lib
gap-pkg-circle.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-circle/COPYING
2 packages and 0 specfiles checked; 1 errors, 10 warnings.



Source checksums
----------------
https://github.com/gap-packages/circle/releases/download/v1.6.1/circle-1.6.1.tar.gz :
  CHECKSUM(SHA256) this package     : 16f7cf1159c680c7cf04cc4fbc5ad97486d56afdde6071d39244277d4d02908d
  CHECKSUM(SHA256) upstream package : 16f7cf1159c680c7cf04cc4fbc5ad97486d56afdde6071d39244277d4d02908d


Requires
--------
gap-pkg-circle (rpmlib, GLIBC filtered):
    gap-core

gap-pkg-circle-doc (rpmlib, GLIBC filtered):
    gap-online-help
    gap-pkg-circle



Provides
--------
gap-pkg-circle:
    gap-pkg-circle

gap-pkg-circle-doc:
    gap-pkg-circle-doc



Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -b 1765727 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-{{ target_arch }}
Active plugins: Shell-api, Generic
Disabled plugins: Haskell, fonts, Perl, Ocaml, Python, Java, PHP, R, C/C++, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
2 packages and 0 specfiles checked; 1 errors, 10 warnings.
Comment 2 Jerry James 2019-11-05 05:09:46 UTC 
(In reply to Gerald Cox from comment #1)
> - Package does not own files or directories owned by other packages.
>   Could the using the %dir directive resolve this?
>   See: 
> https://stackoverflow.com/questions/30067649/rpmbuild-common-ownership-of-
> directories

I don't know what rpmlint is talking about here.  If you look at the spec file, you can see in %files that everything owned by this package, and its -doc subpackage, is contained in /usr/lib/gap/pkg/circle-%{version}.  So no, this package does not own any files or directories owned by other packages.  It looks like rpmlint went bonkers on this check for some reason.

> - incorrect-fsf-address /usr/share/licenses/gap-pkg-circle/COPYING
>   In all cases, upstream SHOULD be informed about this. 
>   This is the only requirement with respect to this error.

Sadly, this is almost universally the case in the GAP ecosystem.  I need to go on a crusade and get the GAP community to update all of these ancient license files.  I will inform upstream.

> - only-non-binary-in-usr-lib - invalid warning
>   See:  https://bugzilla.redhat.com/show_bug.cgi?id=436500

Right, I will filter that out with an rpmlintrc file.

Thank you for the review, Gerald.
Comment 3 Gerald Cox 2019-11-05 15:01:01 UTC 
(In reply to Jerry James from comment #2)
> (In reply to Gerald Cox from comment #1)
> > - Package does not own files or directories owned by other packages.
> >   Could the using the %dir directive resolve this?
> >   See: 
> > https://stackoverflow.com/questions/30067649/rpmbuild-common-ownership-of-
> > directories
> 
> I don't know what rpmlint is talking about here.  If you look at the spec
> file, you can see in %files that everything owned by this package, and its
> -doc subpackage, is contained in /usr/lib/gap/pkg/circle-%{version}.  So no,
> this package does not own any files or directories owned by other packages. 
> It looks like rpmlint went bonkers on this check for some reason.

Yeah, I don't either.  I see your exclude and it appears to work.  I installed
your package and manually checked the directories it was complaining about with
rpm -qf and everything checked out ok.

You might try changing the methodology and use the %dir directive instead
as explained in the link above and see if that resolves the spurious error
messages.  

Approved.
Comment 4 Gwyn Ciesla 2019-11-05 21:46:19 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-circle
Comment 5 Fedora Update System 2019-11-06 03:35:02 UTC 
FEDORA-2019-0b25fae248 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0b25fae248
Comment 6 Fedora Update System 2019-11-07 01:44:21 UTC 
gap-pkg-circle-1.6.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0b25fae248
Comment 7 Fedora Update System 2019-11-15 03:01:14 UTC 
gap-pkg-circle-1.6.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.