Bug 176725

Summary: Miscellaneous problems with "pear makerpm"
Product: [Fedora] Fedora Reporter: Tim Jackson <rpm>
Component: php-pearAssignee: Joe Orton <jorton>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: joshkel
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.4.6-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-01-30 15:48:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 173804    
Bug Blocks: 173802, 173980, 176658    
Attachments:
Description Flags
Patch for the spec file incorporating makerpm fixes
none
Rollup fixes to template for RH naming convs and PEAR bug 6047
none
Fix for PEAR bug 5373 (RPMs can't be uninstalled)
none
Additional functionality for makerpm that enables easier distro-specific naming conventions (PEAR bug 6375)
none
Patch for RH/Fedora naming conventions. Also includes patch to generate deps on php-[ext]
none
Patch to put PEAR stuff in the right place none

Description Tim Jackson 2005-12-30 23:57:05 UTC 
Description of problem:
Although it fixes bug #173270 and bug #173814, the current version of PEAR
(1.4.5) has a "pear makerpm" function which has the following problems as far as
Fedora is concerned:

1. (General problem) RPMs cannot be uninstalled. Bug pushed upstream:
http://pear.php.net/bugs/bug.php?id=6373
2. (General problem) Documentation installation causes rpmbuild to fail. Fixed
upstream in CVS: http://pear.php.net/bugs/bug.php?id=6047
3. (Fedora specific) File locations in template.spec do not match RH/Fedora
naming conventions (i.e. /usr/share/pear/...)
4. (Fedora specific) Format of package names and Requires/Provides does not
match new Fedora conventions [Name: php-pear-Package-Name; Provides/Requires:
php-pear(Package_Name)]. Although this is a Fedora-specific problem, the
solution can be facilitated in a generalised way: see
http://pear.php.net/bugs/bug.php?id=6375
5. (Generalish) pear makerpm does not generate deps on php extensions (e.g.
php-pcre). This would be a Good Thing though requires bug #173804 to be resolved.

Since these problems are preventing simple use of "pear makerpm" under Fedora it
would be good to fix them with an updated package, even the ones that may
eventually be fixed upstream. In any case, the Fedora-specific ones are always
going to require local patches since upstream are presumably not going to change
established conventions. Thus, I have patched the Fedora php-pear RPM to resolve
all these problems. Patch list below.

Spec file   : php-pear-spec-makerpm-fixup.patch
Problem  1  : php-pear-1.4.5-template-postun.patch
Problems 2,3: php-pear-1.4.5-template-fixes.patch
Problem  4:   php-pear-1.4.5-makerpm-cleanup.patch
              php-pear-1.4.5-makerpm-rh-namingconvs.patch
Problem  5:   php-pear-1.4.5-makerpm-rh-namingconvs.patch (again)



Version-Release number of selected component (if applicable):
php-pear-1.4.5-5
Comment 1 Tim Jackson 2005-12-30 23:57:05 UTC 
Created attachment 122652 [details]
Patch for the spec file incorporating makerpm fixes
Comment 2 Tim Jackson 2005-12-31 00:02:28 UTC 
Created attachment 122653 [details]
Rollup fixes to template for RH naming convs and PEAR bug 6047
Comment 3 Tim Jackson 2005-12-31 00:04:53 UTC 
Created attachment 122654 [details]
Fix for PEAR bug 5373 (RPMs can't be uninstalled)
Comment 4 Tim Jackson 2005-12-31 00:07:45 UTC 
Created attachment 122655 [details]
Additional functionality for makerpm that enables easier distro-specific naming conventions (PEAR bug 6375)
Comment 5 Tim Jackson 2005-12-31 00:10:47 UTC 
Created attachment 122656 [details]
Patch for RH/Fedora naming conventions. Also includes patch to generate deps on php-[ext]
Comment 6 Joe Orton 2006-01-13 11:20:59 UTC 
Tim; these patches don't seem to actually apply if I upgared to 1.4.6, they
really are for 1.4.5?  Have you got rediffed versions vs 1.4.6 handy?

+ /usr/bin/patch -p0 data/PEAR/template.spec
/local/build/SOURCES/php-pear-1.4.5-template-fixes.patch
patching file data/PEAR/template.spec
Hunk #2 FAILED at 10.
Hunk #3 FAILED at 18.
Hunk #4 FAILED at 52.
3 out of 4 hunks FAILED -- saving rejects to file data/PEAR/template.spec.rej
Comment 7 Tim Jackson 2006-01-13 11:57:07 UTC 
Hmm, the 1.4.6 template.spec has changed so I'm not entirely surprised they
don't apply. I'll do a new set shortly.
Comment 8 Tim Jackson 2006-01-13 13:31:18 UTC 
Created attachment 123160 [details]
Patch to put PEAR stuff in the right place

New patch for 1.4.6 eliminates most of the fixes as they have already been done
upstream. Also makes the detection of PEAR installation generic rather than
FC/RH-specific (as suggested in bug #176733) which means these changes can be
pushed upstream in future (I will do).
Comment 9 Tim Jackson 2006-01-13 13:38:22 UTC 
The rest of the patches (template-postun, makerpm-cleanup and
makerpm-rh-namingconvs) are still needed but all apply fine to PEAR 1.4.6. Need
to be applied in the above order, though, and after the
php-pear-1.4.6-template-fixes.patch (attachment #123160 [details]) that I just uploaded.
Comment 10 Joe Orton 2006-01-30 15:48:39 UTC 
OK, this should all be fixed in 1.4.6-1; please let me know if I've missed
anything, Tim.
Comment 11 Tim Jackson 2006-02-10 11:09:58 UTC 
Looks great Joe - thanks - *except* that there is the huge problem of bug
#173804 - this *really* needs fixing or it will block any attempts either here
or upstream to be able to meaningfully build php-pear RPM packages. 

e.g. if I build PHPUnit2 with "pear makerpm" from your 1.4.6 packages, it's all
cool except when I install it:

# rpm -ivh ../RPMS/noarch/php-pear-PHPUnit2-2.3.3-1.noarch.rpm
error: Failed dependencies:
        php-dom is needed by php-pear-PHPUnit2-2.3.3-1.noarch
        php-spl is needed by php-pear-PHPUnit2-2.3.3-1.noarch

Now, in fact these deps (in Fedora) - well, the php-spl one at least - are
provided by the Core php package, but it just doesn't declare them.